search

cesmix-mit / LAMMPS.jl

MIT License
33 stars 11 forks source link

Add copy kwarg to extract_atom #37

Closed vchuravy closed 3 months ago

codecov-commenter commented 11 months ago

Codecov Report

Merging #37 (c03b066) into main (e67bbc4) will increase coverage by 0.24%. The diff coverage is 75.00%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             main      #37      +/-   ##
==========================================
+ Coverage   36.00%   36.24%   +0.24%     
==========================================
  Files           2        2              
  Lines         375      378       +3     
==========================================
+ Hits          135      137       +2     
- Misses        240      241       +1
Files Coverage Δ
src/LAMMPS.jl 53.96% <75.00%> (+0.19%) :arrow_up:
vchuravy commented 11 months ago

@swyant I had this code laying around. Not sure why though xD

vchuravy commented 3 months ago

With #43 we could close this and tell the user to use gather instead.

swyant commented 3 months ago

Yea I think that's fine, on the assumption that the user can still use extract_atom if they want to access the memory in-place, right?