search

cespare / reflex

Run a command when files change
MIT License
3.35k stars 135 forks source link

Report delete event #58

Closed maysunfaisal closed 5 years ago

maysunfaisal commented 5 years ago

Hello @cespare

We are interested in using reflex for our product to monitor files and dirs to track changes which include create, update and delete. We are currently using inotify but would like to switch to reflex. However as the reflex readme mentioned, it does not report delete events.

Any reason why reflex does not report delete? I am sorry if this has already been answered, but I did not find an explanation for it. I have created a pull request which reports delete.

cespare commented 5 years ago

Hey @maysunfaisal,

I agree that we should be able to report remove events. Unfortunately, it's not this simple, because we also need to know when paths correspond to directories. This is because we expose this detail to the users.

I opened #59 with more details.

If you're interested in the history, it's mostly in 4c6978cbb83d27fb0af0aed7979c3e93af87532d and dee3b810320c5b48c5616475e2c2bef49ebc5aa4.

maysunfaisal commented 5 years ago

Thanks for the reply @cespare