Assorted v2 cleanup - Githubissues

cespare / xxhash

A Go implementation of the 64-bit xxHash algorithm (XXH64)

MIT License

1.79k stars 123 forks source link

Assorted v2 cleanup #16

Closed cespare closed 5 years ago

cespare commented 5 years ago

This is followup for #15.

cespare commented 5 years ago

@ongardie-ebay this PR is mostly just naming/doc/comment changes along with some minor refactoring. The only thing I really added was some tests that will fail if code that shouldn't allocate does. I tend to prefer tests (rather than relying on benchmarks) to lock in that behavior when possible.

cespare commented 5 years ago

Don't you mean a slight perf improvement?

I see this change too; looks like it's due to the changes to the benchmark code in 26315204797e07a5e9a825080a37ababf62404d3.

cespare commented 5 years ago

Thanks for the review Diego.

ongardie-ebay commented 5 years ago

Don't you mean a slight perf improvement?

Oops, yep, can't complain then.