search

cespare / xxhash

A Go implementation of the 64-bit xxHash algorithm (XXH64)
MIT License
1.79k stars 123 forks source link

Release xxhash v2 #17

Closed cespare closed 5 years ago

cespare commented 5 years ago

We'll have a minor backwards incompatibility so we should bump the major version.

ongardie-ebay commented 5 years ago

@cespare, do you plan to include any other changes in the v2 release?

ongardie-ebay commented 5 years ago

Oh, I see there's a v2 milestone.

cespare commented 5 years ago

Released.

Dieterbe commented 5 years ago

We'll have a minor backwards incompatibility so we should bump the major version.

as an outsider, this is pretty hard to figure out. https://github.com/cespare/xxhash/releases doesn't have a changelog i did some spelunking and found https://github.com/cespare/xxhash/issues/13#issuecomment-442296125 ; is it correct to say that the only breaking change is the rename of the type?

cespare commented 5 years ago

It's not the renaming of the type that's backward-incompatible (since the old name, xxh, wasn't exported anyway). It's just the fact that New changed its signature from New() hash.Hash64 to New() *Digest. And yeah, that was the only breaking change.