search

cespare / xxhash

A Go implementation of the 64-bit xxHash algorithm (XXH64)
MIT License
1.79k stars 123 forks source link

Fix go vet complaints #33

Closed klauspost closed 4 years ago

klauspost commented 4 years ago

Go vet has a few complaints:

λ go vet ./...
# github.com/cespare/xxhash/v2
.\xxhash_amd64.s:182:1: [amd64] writeBlocks: unknown variable b_base; offset 8 is arg1_base+8(FP)
.\xxhash_amd64.s:183:1: [amd64] writeBlocks: unknown variable b_len; offset 16 is arg1_len+16(FP)
.\xxhash_amd64.s:188:1: [amd64] writeBlocks: unknown variable d; offset 0 is arg+0(FP)
.\xxhash_amd64.s:212:1: [amd64] writeBlocks: unknown variable b_base; offset 8 is arg1_base+8(FP)

The fix just does what it asks.

cespare commented 4 years ago

Thanks Klaus. I'd rather fix this by adding names, though; see d7df74196a9e781ede915320c11c378c1b2f3a1f.