cessda / cessda.cdc.aggregator.oai-pmh-repo-handler

Component that provides an OAI-PMH endpoint so that metadata can be harvested by other aggregators
European Union Public License 1.2
0 stars 0 forks source link

oai_datacite renders invalid datacite (kernel-3) #35

Closed cessda-bitbucket-importer closed 1 year ago

cessda-bitbucket-importer commented 1 year ago

Original report on BitBucket by Toni Sissala (GitHub: toni-sissala).


Use of xml:lang in multiple elements:

Invalid element/structure:

cessda-bitbucket-importer commented 1 year ago

Original comment by Toni Sissala (GitHub: toni-sissala).


Using Datacite schema v4 would allow

However, the OpenAIRE guidelines states: “OpenAIRE has adopted the DataCite Metadata Schema v3.1 with some minor adjustments.” at https://guidelines.openaire.eu/en/latest/data/use_of_datacite.html The minor adjustments are also listed, but they do not include allowing xml:lang attributes to elements listed in the issues description.

To target OpenAIRE, we’re stuck with schema v3 and the xml:lang issues need to be fixed.

Also the GeoLocationPlace element needs to be fixed since it is just plain wrong and needs to be wrapped inside a GeoLocation element.

cessda-bitbucket-importer commented 1 year ago

Original comment by Toni Sissala (GitHub: toni-sissala).


Add hard-coded resourceType to 'oai_datacite' metadata

Add hard-coded resourceTYpe to 'oai_datacite' serialization which always has the value 'Dataset'.

This implementation requires the aggregator OAI-PMH Repo Handler to overwrite the template for 'oai_datacite' in Kuha2. Therefore the test coverage that has been built for Kuha2, must also be included and suited for this package.

Kuha2 oai_datacite template was previously fixed to not contain invalid xml:lang attributes and has wrapped geoLocationPlace inside a geoLocation element. As this commit copies the original template from Kuha2, the issues with invalid Datacite v3 are also fixed.

Bump version to 0.4.0.

Write unreleased changelog entry for 0.4.0.

Fixes #33 at Bitbucket. Fixes #35 at Bitbucket.

cessda-bitbucket-importer commented 1 year ago

Original comment by Matthew Morris (GitHub: matthew-morris-cessda).


Merged in feature/33-include-resourcetype-in-oai-datacite (pull request #51)

Add hard-coded resourceType to 'oai_datacite' metadata

Add hard-coded resourceTYpe to 'oai_datacite' serialization which always has the value 'Dataset'.

This implementation requires the aggregator OAI-PMH Repo Handler to overwrite the template for 'oai_datacite' in Kuha2. Therefore the test coverage that has been built for Kuha2, must also be included and suited for this package.

Kuha2 oai_datacite template was previously fixed to not contain invalid xml:lang attributes and has wrapped geoLocationPlace inside a geoLocation element. As this commit copies the original template from Kuha2, the issues with invalid Datacite v3 are also fixed.

Bump version to 0.4.0.

Write unreleased changelog entry for 0.4.0.

Fixes #33 at Bitbucket. Fixes #35 at Bitbucket.

cessda-bitbucket-importer commented 1 year ago

Original comment by Toni Sissala (GitHub: toni-sissala).


Update version. This was not released as a patch release, but was bundled together with features that lead to a minor release.