cessda / cessda.cdc.versions

Issue track and wiki for the CESSDA Data Catalogue
https://datacatalogue.cessda.eu/
Apache License 2.0
0 stars 0 forks source link

Fix static analysis warnings #203

Closed cessda-bitbucket-importer closed 4 years ago

cessda-bitbucket-importer commented 4 years ago

Original report on BitBucket by John Shepherdson (GitHub: john-shepherdson).


Spring cleaning. Also update copyright statement in header of any files that are touched.

cessda-bitbucket-importer commented 4 years ago

Original comment by John Shepherdson (GitHub: john-shepherdson).


See hotfix-203-fix-static-analysis-warnings branch

cessda-bitbucket-importer commented 4 years ago

Original comment by Matthew Morris (GitHub: matthew-morris-cessda).


I’ve created a new branch, 203-add-shifleft-scan, to run more static analysis.

cessda-bitbucket-importer commented 4 years ago

Original comment by John Shepherdson (GitHub: john-shepherdson).


cessda.cdc.osmh-indexer.cmm: Commit c276eb8 has zero SA warnings

cessda-bitbucket-importer commented 4 years ago

Original comment by John Shepherdson (GitHub: john-shepherdson).


cessda.cdc.osmh-repository-handler.nesstar: Commit f0cf5d4 has zero SA warnings

cessda-bitbucket-importer commented 4 years ago

Original comment by John Shepherdson (GitHub: john-shepherdson).


cessda.cdc.osmh-repository-handler.oai-pmh: Commit dba8685 has zero SA warnings

cessda-bitbucket-importer commented 4 years ago

Original comment by John Shepherdson (GitHub: john-shepherdson).


All existing SA warnings have been addressed.

cessda-bitbucket-importer commented 4 years ago

Original comment by John Shepherdson (GitHub: john-shepherdson).


Copyright year updated, but need a better way in future to do this.

cessda-bitbucket-importer commented 4 years ago

Original comment by Matthew Morris (GitHub: matthew-morris-cessda).


Because the license headers are managed by the license-maven-plugin, they can be updated by changing the project.inceptionYear and then running mvn license:format.