cessda / cessda.cvs.two

Apache License 2.0
0 stars 2 forks source link

Ensure new/modified code is covered by unit tests #370

Open cessda-bitbucket-importer opened 2 years ago

cessda-bitbucket-importer commented 2 years ago

Original report on BitBucket by John Shepherdson (GitHub: john-shepherdson).


A a matter of good practice, unit tests should be provided.

As a matter of CESSDA policy, test coverage should be at least 80% (relaxed to 50% for beta releases), see https://docs.tech.cessda.eu/software/quality-gate.html

If the Quality Gate is not passed, the build is failed and release cannot go ahead.

To see new/recent code that has no test coverage, look at the Technical Debt section of SonarQube https://sonarqube.cessda.eu/component_measures?id=eu.cessda.cvs%3Acvs&metric=new_technical_debt&view=list

cessda-bitbucket-importer commented 2 years ago

Original comment by Joshua Tetteh Ocansey (GitHub: Joshocan).


Related to Issue #346 and #283

cessda-bitbucket-importer commented 2 years ago

Original comment by Taina Jääskeläinen.


Note that this only applies to Java code.

cessda-bitbucket-importer commented 2 years ago

Original comment by John Shepherdson (GitHub: john-shepherdson).


Examples of Typescript test are here: https://github.com/cessda/cessda.cdc.searchkit/blob/master/tests/

cessda-bitbucket-importer commented 1 year ago

Original comment by John Shepherdson (GitHub: john-shepherdson).


Recent builds are failing the Quality Gate: https://sonarqube.cessda.eu/dashboard?id=eu.cessda.cvs%3Acvs

Bugs, test coverage and duplication need to be addressed.

Lorenz1983 commented 4 months ago

@matthew-morris-cessda @pakoselo What about the issue's progress?

pakoselo commented 4 months ago

This is ongoing and the purpose is just to not forgot, that every new feature should have also tests for it.

Lorenz1983 commented 4 months ago

@pakoselo Then I mark it with "help wanted" so that extra attention is paid to it.

pakoselo commented 4 months ago

can be