search

cessda / cessda.cvs.two

Apache License 2.0
0 stars 2 forks source link

Deprecation in TL publication pop-up #423

Closed cessda-bitbucket-importer closed 2 years ago

cessda-bitbucket-importer commented 2 years ago

Original report on BitBucket by Taina Jääskeläinen.

When a code is deprecated in SL, this publication pop-up:

‌

In a TL publication pop-up, similar information should be displayed. Currently the TL publication pop-up:

So deprecated codes info should be in TL pop-up, just like added codes.

‌

You can view the current behaviour by opening the publication pop-up in staging for AnalysisUnit FI or IT language versions.

cessda-bitbucket-importer commented 2 years ago

Original comment by Stefan Dlugolinsky (GitHub: Stifo).

Cause: Code deprecation can only be made in a SL. When a code is deprecated in a SL, a change is recorded in a log of that particular SL version. Since each SL and TL version has its own change log, changes recorded in a log for SL are not visible by TL.
Solution: Maybe we can copy SL change log + version changes into TL, when creating TL from SL… I’ll take a look at it.

Note: The deprecation is shown in a comparison table because it is a diff between the content of two consequent TL versions.

cessda-bitbucket-importer commented 2 years ago

Original comment by Taina Jääskeläinen.

Yes, copying the SL change log and version changes into TL would be a good solution.

This would be done for TL publication pop-up when there are the following two changes in the SL:

‌

cessda-bitbucket-importer commented 2 years ago

Original comment by Stefan Dlugolinsky (GitHub: Stifo).

Meantime, I had a discussion with Martin Seleng that there will be no publication pop-up for TL since #394.
I think that this issue should wait until #394 is ready.

Also, it is not easy to copy only deprecation related changes from the SL change log since user may edit the change log when publishing SL and thus make it impossible to parse for some cases. I wonder, whether copying the whole SL change log into the TL change log would be OK.

cessda-bitbucket-importer commented 2 years ago

Original comment by Stefan Dlugolinsky (GitHub: Stifo).

wait for #394 to be completed

cessda-bitbucket-importer commented 2 years ago

Original comment by Taina Jääskeläinen.

Good idea to wait till #394 is completed.

Then at the point when the SL is in status ‘Ready to be translated’, the system could copy from the SL change log for added and deprecated codes into into TL change log (if technically possible) As the change log is also copied to ‘Version notes’, these would be included.

It does not matter that the SL admin can change the ‘Version notes’ later, the change log for these two changes is still valid. The codes remain added or deprecated. If the SL drops this information from the Version changes, they are making a big mistake and it is better that this error is not reflected in the TL version history.

cessda-bitbucket-importer commented 2 years ago

Original comment by Stefan Dlugolinsky (GitHub: Stifo).

Deprecation change log is not copied to ‘Version changes’ element:

‌

cessda-bitbucket-importer commented 2 years ago

Original comment by Taina Jääskeläinen.

Issue #427 was marked as a duplicate of this issue.

cessda-bitbucket-importer commented 2 years ago

Original comment by Stefan Dlugolinsky (GitHub: Stifo).

fixed, should be ready to test in the next dev+staging deployment (within 2 hours)

cessda-bitbucket-importer commented 2 years ago

Original comment by Taina Jääskeläinen.

Cannot test for now this as I seem to have lost the deprecation button in as ADMIN_content as well (#440).

cessda-bitbucket-importer commented 2 years ago

Original comment by Taina Jääskeläinen.

Tested in staging: code deprecation information is now copied to Version changes field in the ‘Ready to publish’ pop-up.

Deprecation also visible in change logs and compariston table.

This pop-up is OK now.

(Except for the version number change which will be dealt with in the versioning issue)