Remove certain roles from User management

[cessda-bitbucket-importer]

Original report on BitBucket by Taina Jääskeläinen.

---

This issue is related to #395 (review of agency roles).

Remove the following Agency roles from the User management section:

• Contributor SL
• Contributor TL

‌

Currently:

‌

‌

I do not know whether we need ‘View’, either. This is for unregistered users who are not entered into user management. Does the system require it to be here?

[cessda-bitbucket-importer]

Original comment by Martin Bobak.

---

As we agreed on, I removed the following roles from user management: ADMIN, CONTRIBUTOR_SL, CONTRIBUTOR_TL, and VIEW.

@‌TainaFSD please test it.

[cessda-bitbucket-importer]

Original comment by Taina Jääskeläinen.

---

Martin, I can still see these roles in user management in staging (and production).

‌

‌

‌

But maybe the change has not been deployed to staging yet?

[cessda-bitbucket-importer]

Original comment by Martin Bobak.

---

I checked it, and the fix is in dev. @Joshocan and @john-shepherdson , is the deployment pipeline changed?

[cessda-bitbucket-importer]

Original comment by Joshua Tetteh Ocansey (GitHub: Joshocan).

---

@‌Martin Bobak No, what is missing?

[cessda-bitbucket-importer]

Original comment by Martin Bobak.

---

I (as well as Taina) expected to have new changes in staging, however, my fix is in dev, but not in staging. I merged its bugfix branch with the master branch as I did it previously. Do I have to merge new branches differently?

[cessda-bitbucket-importer]

Original comment by Joshua Tetteh Ocansey (GitHub: Joshocan).

---

@‌Martin Bobak No, changes are deployed to dev and staging upon merging.

Let me look into it.

[cessda-bitbucket-importer]

Original comment by Martin Bobak.

---

The name of the branch is bugfix/436. It looks like the merging process is complete and correct, but it was performed on dev instead of staging.

[cessda-bitbucket-importer]

Original comment by Joshua Tetteh Ocansey (GitHub: Joshocan).

---

@‌Martin Bobak Does #436 require a certain database schema?

CVS database types in dev and staging are different; Dev uses Mysql 8.0 while staging uses Mysql 5.7. Maybe that could be the problem.

[cessda-bitbucket-importer]

Original comment by Joshua Tetteh Ocansey (GitHub: Joshocan).

---

Created issue #448 to take care of database migration.

[cessda-bitbucket-importer]

Original comment by Martin Bobak.

---

Yes, Mysql 8.0 could be the reason why the fix is in dev. If I understand it correctly, Mysql 8.0 will be in all new bugfixes and features, since some previous bugfix or feature requires it (my fix does not need it).

[cessda-bitbucket-importer]

Original comment by Joshua Tetteh Ocansey (GitHub: Joshocan).

---

@‌Martin Bobak Please test and see if it works. the issue is that the pipeline broke (might not relate to the database). However, #448 will be resolved anyway.

‌

[cessda-bitbucket-importer]

Original comment by Taina Jääskeläinen.

---

In dev, the extra roles have been removed and only the requested two roles ADMIN_S and ADMIN_TL remain.

In staging, all the six roles are still there.

[cessda-bitbucket-importer]

Original comment by Martin Bobak.

---

@Joshocan what do you mean by testing? Should I create a “testing commit” to trigger a rebuild of staging or just to check staging?

[cessda-bitbucket-importer]

Original comment by Joshua Tetteh Ocansey (GitHub: Joshocan).

---

@‌Martin Bobak I was in the helm deployment to staging and it is fixed now. The staging should be working fine with changes now.

[cessda-bitbucket-importer]

Original comment by Taina Jääskeläinen.

---

Thanks, @Joshocan and @‌Martin Bobak .

Test successful: the user management in staging now has only the two requested roles.

I will close the issue.