New workflow: amendments to exports

[cessda-bitbucket-importer]

Original report on BitBucket by Taina Jääskeläinen.

---

When I published the first version of the KungPao vocabulary (SL en and TL fi):

• the PDF and HTML exports had license logo and license text.

‌

‌

‌

I created a new version of the TL fi, without SL changing. Published the new version of KungPao vocabulary as SL admin:

• in the new published version, the PDF and HTML exports did not contain license logo and license text.

‌

‌

‌

So the license logo and text only appear in the first ever published version in the exports.

[cessda-bitbucket-importer]

Original comment by Taina Jääskeläinen.

---

Other amendments:

1. When I have a vocabulary in the status where SL is ‘Ready to be translated’ and TL is in ‘Draft’ status, the content of the exports should be from these drafts. I had added a new code into SL and the new code is visible in the TL table but is not in the exports. Therefore, the exports are based on the latest published version. In the Editor, they should be from the latest SL and TL drafts since they are needed for outsider reviews. By draft I mean all other statuses except the ‘Published’ status.

2. PDF and HTML exports in general:

   1. 'Copyright and license' subtitle should be changed to: 'License and citation'.
   2. Add empty row between the license and citation information.
   3. Would it be possible to drop the 'Deprecated codes list' when empty without it requiring a lot of effort?

‌

[cessda-bitbucket-importer]

Original comment by Taina Jääskeläinen.

---

@Stifo Should I assign this to you?

[cessda-bitbucket-importer]

Original comment by Taina Jääskeläinen.

---

Assigning to Stefan but lower priority than versioning.

[MajaDolinar]

I am testing this on staging. In editor mode I am trying to export drafts, however export does not work. Export does not work outside editor also in staging. Please check so that I can test this issue.

[Stifo]

• found a bug in export of PDF and HTML for DDI Alliance - fixed, not yet merged in the main branch
• fixed 2.i, 2.ii, and 2.iii - not yet merged in the main

[Stifo]

• looks like the 1. was already fixed - SL and TL exports contain new codes
• will merge and mark this issue as resolved once it got an approval review

[MajaDolinar]

Tested on staging for Analysis unit and Aggregation method - the exported pdf did not contain the license logo. All other things noted in this issue are resolved. When I do the same on production, the logos are exported - this seems to be an issue only on staging since this logo issues are present throughout the application (see https://vocabularies-staging.cessda.eu). Is this correct @Stifo ? I believe the exported pdf on production will contain also the license logo? Please correct me if I am wrong, so that I can close this issue.

[Stifo]

the problem with logos on dev and staging is most probably due to missing files in these instances (/content/images/agency/*.jpg) as the logo images were probably uploaded to production only. on dev and staging, requesting logo file gives 404 error:

{
    "timestamp": "2023-10-18T11:38:20.155+0000",
    "status": 404,
    "error": "Not Found",
    "message": "No message available",
    "path": "/content/images/agency/44332555-52c2-48f6-8827-c0548d515985.jpg"
}

[john-shepherdson]

See #796

[MajaDolinar]

Issue resolved. Ready for release.