Add code deprecation for SL admin

[cessda-bitbucket-importer]

Original report on BitBucket by Taina Jääskeläinen.

---

When creating a new SL, content admin has the ‘Deprecate code’ button. Add this button for SL Admin.

‌

Current SL Admin buttons for creating new SL (deprecation missing):

‌

‌

‌

‌

Current content admin buttons (deprecation is there):

‌

‌

‌

[cessda-bitbucket-importer]

Original comment by Stefan Dlugolinsky (GitHub: Stifo).

---

‌

@‌TainaFSD Please, can you explain what exactly is content admin and SL admin? What are the differences?

Looking into the user management I see following roles:

• System roles: ROLE_ADMIN, ROLE_ADMIN_CONTENT, …

• Agency roles (role per agency and language): ADMIN, ADMIN_SL, ADMIN_TL, …

  • I assume that ADMIN = ADMIN_SL + ADMIN_TL

Currently, deprecation button is restricted to show only for agency roles ADMIN and ADMIN_SL + (major version >= 1 and minor version > 0 → bug; e.g.: it won’t show for version 2.0)

‌

[cessda-bitbucket-importer]

Original comment by Stefan Dlugolinsky (GitHub: Stifo).

---

I’ve looked at the “kung pao” dictionary in staging and I think that the cause of this error is in checking the version constrains. In staging, the vocabulary version is 3.0. Code deprecation button is not shown for versions x.0 (minor version is 0). I’ve fixed this to not show code deprecation button just to very first versions; i.e., version == 1.0.

[cessda-bitbucket-importer]

Original comment by Taina Jääskeläinen.

---

Your fix is correct: only the very first versions (i.e. where the first two digits are 1.0) should not have code deprecation. I’ll check it in staging.

‌

If it helps, here is a short explanation of the roles

I’m not quite sure what ROLE_ADMIN does.

ADMIN_CONTENT which I called ‘content admin’ and which in the user roles table is ‘Administrator_content’ has rights to:

• User, agency and licence management across all agencies. They can add, edit, delete users, agencies and licenses and assign roles to users.
• Do anything in any vocabulary content. SL and TL.s Create, edit, deprecate, publish.
• This role is reserved for the Service Owner, that is, to myself and Maja. The Service Owner’s organisation may have a deputy Service Owner who may also have content admin rights.

ADMIN_AGENCY which is currently not yet implemented but Martin B is working on the roles

• User and agency management for their agency.
• Do anything in vocabulary content in SL and TLs in their agency.

SL_Admin

• Can create, edit, deprecate, add new version, and delete draft versions in SL in their particular agency.
• They also have the right to publish the vocabulary, that is, publish the SL and all TLs that are in status ‘Ready to be published’ at that point.

TL_Admin

• Can add translation, edit it, delete draft versions in TL in their particular agency.
• Do not have right to publish anymore. They put finalised translation in status ‘Ready to be published’, and SL_Admin will publish at some point.

‌

[cessda-bitbucket-importer]

Original comment by Taina Jääskeläinen.

---

Still no deprecation button for SL Admin. I created new version of KunPao (DRAFT 3.1) as SL Admin but do not yet have the code deprecation button.

Tested in Chrome on Friday 14th as well.

[cessda-bitbucket-importer]

Original comment by Taina Jääskeläinen.

---

I seem to have lost the deprecation button as content admin as well (both in Firefox and Chrome).

[cessda-bitbucket-importer]

Original comment by Stefan Dlugolinsky (GitHub: Stifo).

---

Hm, I can see it with iisas_guest account in staging:

‌

‌

I’ve changed your roles in staging; i.e., deleted the Agency roles:

‌

To the following:

‌

They’re now the same as for iisas_guest. @‌TainaFSD Can you see the deprecation button now?

[cessda-bitbucket-importer]

Original comment by Taina Jääskeläinen.

---

Yes, I now have the deprecation button in my ROLE_Admin role as [email address removed](mailto:email address removed) in staging.

Still do not have the button in my other staging role [email address removed](mailto:email address removed) where I have SL_ADMIN role for CESSDA and DDI Alliance

• (I have made several Taina-users in staging with different rights for testing purposes).

‌

[cessda-bitbucket-importer]

Original comment by Stefan Dlugolinsky (GitHub: Stifo).

---

There must be a problem with agency roles. It seems that agency roles do not work. This problem is related to #395.

[cessda-bitbucket-importer]

Original comment by Taina Jääskeläinen.

---

I’m reopening this issue so that I remember to check that SL Admin has ‘deprecate code' button when #395 is resolved.

[cessda-bitbucket-importer]

Original comment by Martin Bobak.

---

The deprecation button is accessible for Admin SL.

[cessda-bitbucket-importer]

Original comment by Taina Jääskeläinen.

---

Thanks, Martin. Tested in staging and the deprecation is there for Admin SL.