Comparison table should not include changes from all versions

[cessda-bitbucket-importer]

Original report on BitBucket by Taina Jääskeläinen.

---

It seems that the comparison table has now changed to include changes made to the vocabulary in any version.

The comparison table should only include:

• Changes between the current version and the previous published version in that language.
• The current version is the latest Editor version and in the general UI the latest published version

As SL Admin, I created a new version of TestingCV2 (en). I added a definition to Code10.

In the ‘Ready to translate SL [language code]’ pop-up the change log only included this change but the comparison table included the changes from all the previous versions as well.

‌

‌

The fix is: include in the comparison table only the changes made in the Editor to the new version. This means the same changes that are displayed in the change log.

This applies also to TL ‘Ready to be published’ pop-up and the language specific comparison tables of published versions.

Not sure if this issue came up because of he work done on the versioning.

[cessda-bitbucket-importer]

Original comment by Taina Jääskeläinen.

---

@pakoselo Is this related or not to #446 which seems more or less resolved?

[cessda-bitbucket-importer]

Original comment by Martin Šeleng (GitHub: pakoselo).

---

@‌TainaFSD had added @‌Martin Bobak (maybe an error) as a responsible for this issue, but we had a discussion about that, and we will contact @Stifo as he was working on that.

[cessda-bitbucket-importer]

Original comment by Martin Šeleng (GitHub: pakoselo).

---

@‌TainaFSD in fact it is not related.

[cessda-bitbucket-importer]

Original comment by Taina Jääskeläinen.

---

Martin: sorry and thanks for assigning to Stefan, forgot who was working on what.

[cessda-bitbucket-importer]

Original comment by Stefan Dlugolinsky (GitHub: Stifo).

---

fixed, caused by a bug introduced in the last version of the VersionUtils.java

[cessda-bitbucket-importer]

Original comment by Taina Jääskeläinen.

---

Thanks, Stefan. Checked in staging: comparison table correct in the general UI and the Editor, in draft, published and previous versions.

[cessda-bitbucket-importer]

Original comment by Taina Jääskeläinen.

---

This issue seems to have come up again.

• I made a new SL version of ‘testisanasto’,
• Then ranslated it to FI
• Clicked on ‘Publish CV’ as SL_Admin to publish it. The comparison table that came up when I clicked on ‘Publish CV’ still had the changes made in all previous versions, not just between the previous and current version.

‌

‌

Also detailed study view shows all changes over time when I go to ‘Versions’ tab and open the comparison table for the current version.

[cessda-bitbucket-importer]

Original comment by Stefan Dlugolinsky (GitHub: Stifo).

---

this is due to a bug in the version number migration code. i’ve fixed it already, but we need to reload dev and staging database data from a backup dating before 15:45 of 9.12.2022 CET.

[Stifo]

don't know, why this issue came up as it was already solved by ae5259a861367872e3553d6f69a32e743a5b174d. closing.