cessda / cessda.cvs.two

Apache License 2.0
0 stars 2 forks source link

Action buttons missing #457

Closed cessda-bitbucket-importer closed 1 year ago

cessda-bitbucket-importer commented 1 year ago

Original report on BitBucket by Taina Jääskeläinen.


As ADMIN_SL:

  1. I create a new version of SL for a published vocabulary SoftwarePackage in Editor. The system moves the vocabulary to status ‘draft’. I have all the editing buttons for codes (add, edit, move, deprecate, and for new codes added, delete) and for the CV (Edit SL).
  2. I move the status to ‘Review’. The ‘Edit code’ button has disappeared. All the other code and vocabulary level buttons are there.

Suggested change: Return ‘Edit button’ into ‘Review’ stage for ADMIN_SLs.

As ADMIN_TL:

  1. I create a new TL version of a published vocabulary GeneralDataFormat that had the FI content. I click on ‘Create new FI version' and get the create new version pop-up. The system tells me that a new version is created. However, no action button come up.
  2. I create a new TL FI version for a SL version that is in the status ‘Ready to be translated’ as the ADMIN_SL has created a new version for it. Creating new FI version is OK and I have all the buttons I need.

Suggested change: Assign published SLs the status ‘Ready to be translated’ in the Editor. This way a new language or translation version can always be added without need to create a new SL version. It is up to the translator then to discuss with ADMIN_SL when he or she will publish their changes.

cessda-bitbucket-importer commented 1 year ago

Original comment by Taina Jääskeläinen.


Martin, these issues came up after further changes but were working before the versioning changes. So not sure to whom I would assign it now.

cessda-bitbucket-importer commented 1 year ago

Original comment by Martin Šeleng (GitHub: pakoselo).


@‌TainaFSD the problem is that old vocabularies don’t have the correct version updated in the vocabulary table (in database). If you create new vocabulary, it should work as expected. Please test it. The vocabulary table is broken, we already saw this when you show the old version in editor or home of some vocabulary, the info which points to latest version is not correct. I will work on a shell script to be executed on database to correct these information.

cessda-bitbucket-importer commented 1 year ago

Original comment by Taina Jääskeläinen.


I have tested: when creating a new vocabulary, it is working as expected. The action buttons for SLs and TLs are there when creating new versions.

So like you say, it seems to be an issue for previously published vocabularies and their updates in the database.

cessda-bitbucket-importer commented 1 year ago

Original comment by Martin Šeleng (GitHub: pakoselo).


@‌dolinarm After taking some database dump from December and executing the script I submit in the Issue #446, the problems mentioned by @‌TainaFSD disappeared. All of the action buttons are there, when following steps mentioned above. As it is still not executed against the dev/staging database cannot be tested right now. Changing the status to resolved.

cessda-bitbucket-importer commented 1 year ago

Original comment by Maja Dolinar.


Ok, will wait until I am able to test this on dev before closing the issue.

cessda-bitbucket-importer commented 1 year ago

Original comment by Maja Dolinar.


Checked for ADMIN_SL and the issue is resolved.

Need to check for ADMIN_TL when I will have ADMIN_TL access again.

cessda-bitbucket-importer commented 1 year ago

Original comment by John Shepherdson (GitHub: john-shepherdson).


In preparation for release