cessda / cessda.cvs.two

Apache License 2.0
0 stars 2 forks source link

TL change logs and 'Version changes' content #458

Closed cessda-bitbucket-importer closed 1 year ago

cessda-bitbucket-importer commented 1 year ago

Original report on BitBucket by Taina Jääskeläinen.


Only SL change logs seem to be copied to TL change logs.

cessda-bitbucket-importer commented 1 year ago

Original comment by Taina Jääskeläinen.


I created a third version of SL COVIDCA (1.1.0). One change: Code descriptive term rephrased - COVIDTransmissionProcess

When translating and moving a TL status to ‘Ready to be published’ and getting the pop-up with version information:

  1. In FI translation (logged in as TL_ADMIN), in the pop-up change logs included both SL change and TL change. Only SL change was copied to ‘Version changes’.
  2. In SV translation (logged in as CONTENT_ADMIN), in the pop-up change log included only the TL change, no SL change. Only TL change was copied to ‘Version changes’.

  1. case pop-up FI - SL change copied, change logs contain both

2. case pop-up SV - SL change copied, change log contains only TL change

I do not know if this difference is due to the role, or due to the fact that there was no SV in version 1.0.0, as SV translations were made only for 1.1.0 and 1.2.0.

Finnish FI translations were made also for all three versions, including 1.0.0.

cessda-bitbucket-importer commented 1 year ago

Original comment by Taina Jääskeläinen.


Ideal situation for the new TL ‘Ready to publish’ pop-up:

As not sure how much work this would be, at this point of development would suffice:

When the TL user clicks open ‘Ready to publish’ and there is some content in the change logs, the system first gives the user a notification that says:

TL changes are automatically copied to ‘Version changes’ field. Review the comparison table and change logs to check all changes are documented in ‘Version changes’. Add missing ones manually.

In addition, review the comparison table and change logs and enter those SL changes that affect your language but are missing (deprication of codes, changes in code values or added codes) to ‘Version changes’.

‘Close’ button (at which point the pop-up opens)

pakoselo commented 1 year ago

@MajaDolinar I am not sure I got the problem. Images are missing. I tried to create new version of SL, with changing the code definition and adding new code and it also shows the later change (add code) in the TL. Can you please elaborate it little bit more?

MajaDolinar commented 1 year ago

Yes, I am also having trouble reproducing this and understanding what the issue behind this is. That is why I haven’t provided you with screenshots yet. I will investigate further and hopefully clarify this in the coming days.

pakoselo commented 1 year ago

Maybe it was during the deployment of the new 3 digit versioning system + the change in the workflow. And later it disappears. But will wait for your further tests.

MajaDolinar commented 1 year ago

I do not understand what this issue is about. Closing the issue for now, will not be worked on.