search

cessda / cessda.cvs.two

Apache License 2.0
0 stars 2 forks source link

Comparison table contains all changes over time #483

Closed cessda-bitbucket-importer closed 1 year ago

cessda-bitbucket-importer commented 1 year ago

Original report on BitBucket by Taina Jääskeläinen.

I’m changing a code + its term in the CDCPublisherNames vocabulary in the Editor in Production.

  1. I’ve done the code-level change
  2. Moved the code to a new place in the list
  3. Clicked on ‘Ready to translate SL en’ button to enter version history. Noticed that the comparison table in the pop-up contains 47 differences, so it shows all history, not just between the previous and the new one.
  4. I finalised the ‘Version changes’ and ‘Version notes’ elements and changed the version number but saved the information in the pop-up instead of changing status so you can take a look. The vocabulary is still in REVIEW stage.

‌

Should I publish it and see what the comparison table shows or is it better that I leave it in REVIEW for IISAS to take a look? I know this issue was already solved once but seems to have reoccurred in this instance.

I don’t know whether my moving the code to another place had any impact on the issue. The publisher list is alpabetical so I needed to move the amended code to its right place (UniData changed to DASSI).

cessda-bitbucket-importer commented 1 year ago

Original comment by Taina Jääskeläinen.

@‌dolinarm Maja, for your information.

@Stifo Related to #453 or its duplicate. As you may not see the Editor in production version, should I publish the vocabulary for you to see the problem or can IISAS see the problem in the dev version, is it up-to-date with production?

Just asking because I need to publish the vocabulary soon.

cessda-bitbucket-importer commented 1 year ago

Original comment by Taina Jääskeläinen.

It seems this may have been my fault as Imay not have done the deprecation properly.

I deleted the CV version in the Editor in production and tried again, doing the deprecation properly.

Now the neew version of the vocabulary is published, the comparison table is correct and there is also correct deprecation information.

Closing the issue.