Closed cessda-bitbucket-importer closed 1 year ago
Original comment by John Shepherdson (GitHub: john-shepherdson).
@pakoselo Not convinced this is an issue for Oliver. This has broken recently, not due to Oliver’s intervention as far as I know (his most recent commit was on 2022-04-28)
Original comment by Martin Šeleng (GitHub: pakoselo).
@Joshocan @john-shepherdson @dolinarm This script https://github.com/cessda/cessda.cvs.two/issues/484 will solve the issue. @Joshocan Please try to execute it on dev or staging, if it works. Locally it works. Actually it should work there. I didn’t test it, but it should as the script was already deployed on staging and dev.
Original comment by Joshua Tetteh Ocansey (GitHub: Joshocan).
The script in #484 is already executed on dev and staging.
Original comment by John Shepherdson (GitHub: john-shepherdson).
Checked SKOS export for DDI Alliance Controlled Vocabulary for Aggregation Method
Nulls present (production instance)
No nulls (staging instance)
Original comment by John Shepherdson (GitHub: john-shepherdson).
Cannot be closed until script has been run (and SKOS export checked) on Production instance.
N.B. make a database backup before running the script
Original comment by Martin Šeleng (GitHub: pakoselo).
@john-shepherdson it is not marked as closed, but as resolved. It should be marked as oder, agent it will be applied to the production DB. If I remember correctly, we decided to use the resolved by us and closed by you.
Original comment by John Shepherdson (GitHub: john-shepherdson).
Yes, we agreed that IISAS mark issues as resolved once the fix has been committed to the main branch, and CESSDA tests in staging and either closes or re-opens the issue.
However, this is not a code fix, so deploying the codebase to production will not resolve the issue. I want to keep it open as a reminder that the script must be run against production as part of the release of v3.0.1
We should discuss a code-based approach for future database changes, so that we do not run the risk of releasing a new version but not running the database script (which happened recently).
Original comment by Maja Dolinar.
Seems to be working fine now on staging. Keeping the issue as resolved so that comment from John is put into consideration.
Original report on BitBucket by John Shepherdson (GitHub: john-shepherdson).
Hi Maja, When exporting e.g. Topic Classification in SKOS, the files contains nulls, see this example:
Raised by Mari Kleemola via EOSC Helpdesk (see https://eosc-helpdesk.eosc-portal.eu/#ticket/zoom/2312)