cessda / cessda.cvs.two

Apache License 2.0
0 stars 2 forks source link

Unmapped Mapstruct properties warnings are emitted when compiling CVS #805

Closed matthew-morris-cessda closed 1 month ago

matthew-morris-cessda commented 8 months ago

When compiling CVS the following warnings are emitted from the Java compiler.

[WARNING] /home/jenkins/agent/workspace/cessda.cvs.two_PR-804/src/main/java/eu/cessda/cvs/service/mapper/VocabularyPublishMapper.java:[32,19] Unmapped target properties: "statusByVocabularySnippet, versionNumberByVocabularySnippet, contentByVocabularySnippet, agencyLink, versions, removeVersion, languages, statuses".
[WARNING] /home/jenkins/agent/workspace/cessda.cvs.two_PR-804/src/main/java/eu/cessda/cvs/service/mapper/VocabularyMapper.java:[32,19] Unmapped target properties: "statusByVocabularySnippet, versionNumberByVocabularySnippet, contentByVocabularySnippet, agencyLink, codes, removeVersion, languages, languagesPublished, statuses".
[WARNING] /home/jenkins/agent/workspace/cessda.cvs.two_PR-804/src/main/java/eu/cessda/cvs/service/mapper/VersionMapper.java:[31,16] Unmapped target properties: "copyright, licenseName, licenseLink, licenseLogo, removeConcept, removeComment, versionHistories, contentByVocabularySnippet, deprecatedConceptsValidUntilVersionId".
[WARNING] /home/jenkins/agent/workspace/cessda.cvs.two_PR-804/src/main/java/eu/cessda/cvs/service/mapper/VocabularyEditorMapper.java:[33,19] Unmapped target properties: "statusByVocabularySnippet, versionNumberByVocabularySnippet, contentByVocabularySnippet, agencyLink, versions, removeVersion, languagesPublished".

These properties should be properly mapped, or the warnings should be suppressed.

john-shepherdson commented 8 months ago

See also https://helpdesk.cessda.eu/#ticket/zoom/4279

Screenshot 2024-04-09 at 12 54 55

matthew-morris-cessda commented 8 months ago

This is something that we need IISAS to look at, as they should know what properties need to be mapped from the database entity to the DTO

pakoselo commented 1 month ago

Resolved and merged to main: https://github.com/cessda/cessda.cvs.two/pull/880