search

cessen / openexr-rs

This repository has been moved to https://github.com/vfx-rs/openexr-rs
MIT License
23 stars 10 forks source link

Clippy fixes, add to run Clippy on nightly builds on Travis #21

Closed Twinklebear closed 6 years ago

Twinklebear commented 7 years ago

This PR fixes some various lints from clippy and adds the unstable feature to run clippy on Travis builds with the nightly compiler as well, to pick up new lints on each commit.

I've left some clippy lints unfixed (about the documentation formatting, and some on too many params for a function), but can do these as well. I think the "too many args for function" ones are actually ok.

Ralith commented 7 years ago

If clippy is enabled by default on nightly, won't that lead to spurious failures whenever clippy and nightly are out of sync?

Twinklebear commented 7 years ago

It will, so I've made the nightly build optional to fail. I can also add a non-clippy nightly build which is not allowed to fail in the build matrix to make sure the library is still building on nightly (and not just failing due to clippy).

Ralith commented 7 years ago

Oh, I misread the travis config; the way you have it is fine. Nightly is unstable so failures in it shouldn't be considered blocking.

Ralith commented 6 years ago

Thanks! Sorry for the slow merge.

Twinklebear commented 6 years ago

No worries, thanks!