Add slice_byte() / get_slice_byte()

cessen / ropey

A utf8 text rope for manipulating and editing large texts.

MIT License

1.04k stars 46 forks source link

Add slice_byte() / get_slice_byte() #49

Closed archseer closed 2 years ago

archseer commented 2 years ago

It would be a nice optimization in Helix since we receive byte ranges from tree-sitter then convert them into char indices, but then ropey converts back to bytes and uses byte calculations internally.

cessen commented 2 years ago

Thanks for the linked PR!

There are some additional things I want to address, as I mentioned in the PR. So I'm leaving this open as a reminder to take care of that.

cessen commented 2 years ago

I've now addressed the additional items I mentioned in the original PR.