Fixing travel date query error

raagavi158 commented 1 year ago

Fixing the query matching statement that was causing this error:

"if one does a search in the Explorer for travelers who were in Rome in June 1752 one gets 51 results which all make sense (I have gone through them all individually) but one does not get entry 897, for James Caulfield 4th viscount Charlemont (https://grandtourexplorer.wc.reclaim.cloud/#/entries/897 ), whom I know was in Rome then, but most importantly it is someone whose data in the Explorer show him to be in Rome at that time: why is he missing? "

Original query logic checked if travel end month was gte to query month and if travel start month was lte to query month but this did not take into account the corresponding year constraints at the same time.
Edited query to separately handle when start month and end month are in the same year as the query month and when start and end year were in the same year.

epicfaace commented 1 year ago

@raagavi158 Can you explain a bit more in the PR how you solved it?

epicfaace commented 1 year ago

Also you need to update snapshots (https://github.com/cestastanford/grandtour/actions/runs/4890270184/jobs/8729531969?pr=295). You can do so by running npm run test -- -u.

epicfaace commented 1 year ago

@raagavi158 what are you thinking we should do for this PR?

raagavi158 commented 1 year ago

@epicfaace I think we should push this since it doesn't necessarily return false positives and then maybe work on fine-tuning. Thoughts?

epicfaace commented 1 year ago

@epicfaace I think we should push this since it doesn't necessarily return false positives and then maybe work on fine-tuning. Thoughts?

Are you sure it doesn't necessarily return false positives? If so, yeah, let's push it.

cestastanford / grandtour

Fixing travel date query error #295