NOTES.txt incorrect - Githubissues

cetic / helm-fadi

Helm Chart for FADI

https://github.com/cetic/fadi

Apache License 2.0

13 stars 4 forks source link

NOTES.txt incorrect #2

Closed alexnuttinck closed 4 years ago

alexnuttinck commented 5 years ago

Notes displayed are incorrect. It doesn't use sub-chart informations.

banzo commented 4 years ago

we might also want to change CONGRATULATIONS! FADI has been installed. to CONGRATULATIONS! FADI is being installed.

alexnuttinck commented 4 years ago

It is changed to CONGRATULATIONS! FADI is being installed.

banzo commented 4 years ago

The psql service name printed is incorrect (should be fadi-postgresql instead of fadi-fadi)

➜ helm git:(develop) ✗ export POSTGRES_PASSWORD=$(kubectl get secret --namespace fadi fadi-fadi -o jsonpath="{.data.postgresql-password}" | base64 --decode) Error from server (NotFound): secrets "fadi-fadi" not found

alexnuttinck commented 4 years ago

The Grafana server can be accessed via port 80 on the following DNS name from within your cluster: myrelease.default.svc.cluster.local

Should be myrelease-grafana.default.scv.cluster.local

fix? https://stackoverflow.com/questions/49142353/helm-getting-subchart-service-names

alexnuttinck commented 4 years ago

I simplified the NOTES.txt in the 0.2.4 release. We can close this issue.