cetic / helm-nifi

Helm Chart for Apache Nifi
Apache License 2.0
211 stars 221 forks source link

[cetic/nifi] Use Appach Nifi JVM memory settings by default #207

Open valentindudnik opened 2 years ago

valentindudnik commented 2 years ago

Is your feature request related to a problem? Please describe. I want to use default JVM memory settings but I can't to use it for now, because these settings specified strictly:

JVM memory settings

java.arg.2=-Xms{{.Values.jvmMemory.min}} java.arg.3=-Xmx{{.Values.jvmMemory.max}}

Describe the solution you'd like {{ if .Values.jvmMemory.min }} java.arg.2=-Xms{{.Values.jvmMemory.min}} {{ end }}

{{ if .Values.jvmMemory.max}} java.arg.3=-Xmx{{.Values.jvmMemory.max}} {{ end }}

Describe alternatives you've considered Now I am using default JVM memory settings, I am overriding: jvmMemory = 512m java.arg.2=-Xms512m java.arg.3=-Xmx512m

Additional context Add any other context or screenshots about the feature request here.

banzo commented 2 years ago

@valentindudnik thanks for the information, would you be willing to make a pull request with those changes?

valentindudnik commented 2 years ago

Hi @banzo, yes of course, I can create pull request for those changes