Closed wknickless closed 2 years ago
Test OIDC without a k8s job
The OIDC login test runs in a Kubernetes job, and for some reason the return codes sometimes don't come through properly. This PR eliminates the job in favor of installing the necessary node.js parts in the runner workspace.
@banzo I'll be cherry-picking the included commit https://github.com/wknickless/helm-nifi/commit/85054e8ed3700e71cd45efd05055eb4b72bf0d01 into #218 @gforeman02 recommend cherry-picking https://github.com/wknickless/helm-nifi/commit/85054e8ed3700e71cd45efd05055eb4b72bf0d01 into #243, as I saw it failed on you at least once.
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
Also cherry-picked to #218 as https://github.com/cetic/helm-nifi/pull/218/commits/eb22003a1a2ee59185935cb626bcb588678475bb and https://github.com/cetic/helm-nifi/pull/218/commits/81e9ab1d9d5cc0b9a501b2ba22687821c3917901
wknickless
commented
2 years ago
Test OIDC without a k8s job
What this PR does / why we need it:
The OIDC login test runs in a Kubernetes job, and for some reason the return codes sometimes don't come through properly. This PR eliminates the job in favor of installing the necessary node.js parts in the runner workspace.
Which issue this PR fixes
Special notes for your reviewer:
@banzo I'll be cherry-picking the included commit https://github.com/wknickless/helm-nifi/commit/85054e8ed3700e71cd45efd05055eb4b72bf0d01 into #218 @gforeman02 recommend cherry-picking https://github.com/wknickless/helm-nifi/commit/85054e8ed3700e71cd45efd05055eb4b72bf0d01 into #243, as I saw it failed on you at least once.
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]