cetic / helm-nifi

Helm Chart for Apache Nifi
Apache License 2.0
215 stars 228 forks source link

Add auth.oidc.preferredJwsalgorithm param #306

Closed happy-code-com closed 1 year ago

happy-code-com commented 1 year ago

Which issue this PR fixes

Checklist

happy-code-com commented 1 year ago

I will try to figure out what the problem is with the tests and make corrections.

banzo commented 1 year ago

It might just be limits on container pulls or resources that GitHub enforces.

banzo commented 1 year ago

nope, the OIDC tests seem to be broken. If you have an idea on how to fix them, you are more welcome to share it :)

happy-code-com commented 1 year ago

Hmm. interestingly, in fact nothing was added, just an empty string started to be passed from the parameters... I'll try to think what could be the matter 🤯

wknickless commented 1 year ago

I'm seeing this error in the OIDC Insecure test when fast-forwarding my personal fork from the master branch. Not sure yet what "Error: Timeout cleared" means, but it smells like a change in behavior either in Puppeteer or an underlying node.js component. Investigating further.

Run export K8SNODEIP=$(kubectl get node -o json | jq -r '.items[0].status.addresses[0].address')

  NiFi Login via OIDC
    ✔ NiFi redirects to KeyCloak login page (3600ms)
    ✔ Get screenshot of Keycloak login page (87ms)
    1) nifi@example.com shown as logged in user
    ✔ Get screenshot of logged in user (643ms)

  3 passing (6s)
  1 failing

  1) NiFi Login via OIDC
       nifi@example.com shown as logged in user:
     Error: Timeout cleared
      at Deferred.race (node_modules/puppeteer-core/lib/cjs/puppeteer/util/Deferred.js:94:33)
      at async CDPPage._waitForNetworkIdle (node_modules/puppeteer-core/lib/cjs/puppeteer/api/Page.js:567:9)
      at async CDPPage.waitForNetworkIdle (node_modules/puppeteer-core/lib/cjs/puppeteer/common/Page.js:482:9)
      at async Promise.all (index 2)
      at async Context.<anonymous> (work/helm-nifi/helm-nifi/tests/04-oidc-login-test.js:20:[17](https://github.com/wknickless/helm-nifi/actions/runs/5324729729/jobs/9644451370#step:9:18))

Error: Process completed with exit code 1.
wknickless commented 1 year ago

Looks like we may be running into https://github.com/puppeteer/puppeteer/issues/10398 .

banzo commented 1 year ago

closing so that reopening will retrigger all the checks