cetic / helm-nifi

Helm Chart for Apache Nifi

Apache License 2.0

215 stars 228 forks source link

Make compatible with apache/nifi >= 1.19.0 (#313) #314

Closed jrebmann closed 11 months ago

jrebmann commented 1 year ago

What this PR does / why we need it:

This pull request allows apache/nifi versions >=0.19.0 to be released with this helm chart.

As described in issue #313, this only required the keystore type to be explicitly set to JKS when calling keytool to be compatible with Java 11.

This change is backward compatible with Java 8.

Which issue this PR fixes

fixes #313

Checklist

[X] DCO signed
[ ] Chart Version bumped

jrebmann commented 1 year ago

I just took a look at it. I don't think the build fails because of my change.

The unit test OIDC Logins / OIDC (cluster, Ingress, cert-manager local issuer) fails since commit f296a8e87ea96e05ece9fe8a8a1b6d29d6f4b1ac (Jun 15, 23).

Is the problem already known?

banzo commented 1 year ago

yeah, not sure what's wrong.

319 did not have an issue with the tests, is this PR still relevant?

jrebmann commented 1 year ago

Absolutely! This PR is essential to use Apache NiFi versions >=1.19.0.