cetic / helm-pgadmin

Helm Chart for pgAdmin
Apache License 2.0
16 stars 23 forks source link

Add general environment variables option to support PGADMIN_CONFIG_ overrides as per the container docs #11

Closed patkearney closed 5 years ago

patkearney commented 5 years ago

What this PR does / why we need it:

Adds the ability to set arbitrary environment variables. Given the extent of options that could be overriden in config.py this seemed preferable to exposing each individually.

I was initially unable to deploy a default installation with a LoadBalancer against an AKS cluster. No user credentials worked when accessing via the LoadBalancer IP. There is a note in config.py as per disabling enhanced cookie protection within dynamic IP environments such as Kubernetes.

Which issue this PR fixes

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

alexnuttinck commented 5 years ago

Hello @patkearney,

Thanks for this improvement! It will be helpful.