Add extra parameter to add extra containers with sidecar pattern

[maxenced]

Hi,

first, thanks for all the work you did with this helm chart ! For some reason (we use consul as resolver) we need a custom extra container to be used within our zabbix-server/web pods.

Would you be able to add an extra parameter like extra_containers so that we can define any extra needed containers using sidecar pattern ? Does not look like a big change and would help a lot extending your chart.

Maxence

[aeciopires]

Hi @maxenced!

Thanks for using this helm chart! :-)

You would like that be implemented this 1 or this 2 or both?

Do you can share an example of config that you usually use?

[aeciopires]

Hi @maxenced!

I searched in repository and we implemented this.

You can use now.

https://github.com/cetic/helm-zabbix/search?q=extraContainers

[maxenced]

Well ... i checked the code before asking here, can't understand why I did not see that :/ Thank you !

[maxenced]

~Well, in fact, we also need the extrainitcontainers as we need to resolve consul domain (which is the bdd host) for the initcontainer~ We also need to resolve consul domains inside init container. However, init containers do start one at a time, so not sure how i can handle this. Maybe restricting ourself to only 1 replica is the way to go

[aeciopires]

Ok @maxenced! I will do it using the same implementation (list of config) of the extra Containers. That help you?

[maxenced]

Sorry, i modified while you were answering, see my updated comment ;)

[aeciopires]

I had seen your change, but I was wondering if you still need the extraInitContainer or if you can solve it the way the helm chart is implemented.

[maxenced]

extraInitContainer won't solve it as i need the extra container to be started at same time than your init container, but init containers are started one at a time. For now, we will just avoid using more than one replica so that there is no init container at all. I still have another issue with dns config, but will open a new issue for it ;)