cetmix / cetmix-tower

Cetmix Tower
GNU Affero General Public License v3.0
9 stars 5 forks source link

[14.0][IMP] cetmix_tower_server - 7 commits #102

Open norlinhenrik opened 6 days ago

norlinhenrik commented 6 days ago

Commit 1: A record may be readonly and gray in lists

Standard commands, flight plans, file tamplates, variables and global variable values may be managed e.g. by Odoo modules. To these 5 models, this commit adds a 'readonly' field and makes sure that 'readonly' data records are readonly and gray in list views.

Commit 2: Restrict deleting a record referenced by many2one

Deleting a record may delete related records only in these cases:

Delete flight plan -> Delete related lines Delete flight plan line -> Delete related line actions Delete flight plan log -> Delete related command logs Delete server -> Delete related files, keys and variable values

Commit 3: Show shared commands and plans by default

Optional, set system parameter cetmix_tower_server.any_server = 1

Commit 4: Variable value may be empty.

A server may replace a default value with an empty value. {% if value %} may return False.

Commit 5: Don't allow deleting a server tag if it is used by a server.

Commit 6: Fix something I did wrong when resolving conflicts.

Commit 7: Fix reference

When searching for the existance of a variable, exclude the active record. Otherwise setting the variable reference (e.g. by a module) will result in variable, variable_2, variable, variable_2every second time.

norlinhenrik commented 6 days ago

Superseding #65

ivs-cetmix commented 6 days ago

@norlinhenrik please fix pre-commit issues

norlinhenrik commented 6 days ago

@ivs-cetmix I have fixed the pre-commit issues.

ivs-cetmix commented 6 days ago

/ocabot rebase

CetmixGitDrone commented 6 days ago

Congratulations, PR rebased to 14.0-dev.

norlinhenrik commented 1 day ago

@ivs-cetmix So commit 7 you have implemented already 👍 , and commit 6 is related to commit 2.

Before I write tests and make pull requests, I would like to know if there are any of the 5 first commits which you think should not be implemented?