[14.0][IMP] cetmix_tower_server: 'readonly' field, many2one restrict, shared cmd/plans

norlinhenrik commented 4 months ago

This PR has 3 commits:

1. A record may be readonly and gray in lists

Standard commands, flight plans, file tamplates, variables and global variable values may be managed e.g. by Odoo modules. To these 5 models, this commit adds a 'readonly' field and makes sure that 'readonly' data records are readonly and gray in list views.

2. Restrict deleting a record referenced by many2one

Deleting a record may delete related records only in these cases:

Delete flight plan -> Delete related lines
Delete flight plan line -> Delete related line actions
Delete flight plan log -> Delete related command logs
Delete server -> Delete related files, keys and variable values

3. Show shared commands and plans by default

Optional, set system parameter cetmix_tower_server.any_server = 1

ivs-cetmix commented 3 months ago

Hello @norlinhenrik , thank you very much for your contribution! Please resolve the conflicts so we could check this.

norlinhenrik commented 1 month ago

Hello @norlinhenrik , thank you very much for your contribution! Please resolve the conflicts so we could check this.

Done

norlinhenrik commented 4 weeks ago

@ivs-cetmix Would you like to review?

ivs-cetmix commented 3 weeks ago

@ivs-cetmix Would you like to review?

Sure, will try to do this week. We are preparing for the release which is planned for the 1st of October. So focusing on the MVP features right now.

norlinhenrik commented 3 weeks ago

Have you considered shorter module names?

cetmix_tower
cetmix_tower_queue
cetmix_tower_traefik
cetmix_tower_postgres
cetmix_tower_odoo
cetmix_tower_custom

ivs-cetmix commented 3 weeks ago

Have you considered shorter module names?

cetmix_tower

cetmix_tower_queue

cetmix_tower_traefik

cetmix_tower_postgres

cetmix_tower_odoo

cetmix_tower_custom

We are considering moving configuration out of the Odoo module structures to the external configuration files. Similar to the YAML you proposed however more flexible. The main goal is to make Tower easy to use for people who are not so familiar with Odoo. There are a lot of new features have been merged recently which should make flight plans much more powerful tools. Including but not limited to Python code support in commands.

As for the shorter named modules mentioned above will remain for the technology specific helper modules. Some of them will remain in the main repo, however some of them will be a part of the Pro version which is being developed in parallel. It's based on the base module similar way as Odoo EE is based on CE and includes mostly convenience and productivity enchantments. Such as shortcuts and customer portal.

Aldeigja commented 1 week ago

/ocabot rebase

CetmixGitDrone commented 1 week ago

@Aldeigja The rebase process failed, because command git rebase origin/14.0-dev failed with output:

Rebasing (1/4)
Auto-merging cetmix_tower_server/__manifest__.py
Auto-merging cetmix_tower_server/models/cx_tower_command.py
Auto-merging cetmix_tower_server/models/cx_tower_file_template.py
Auto-merging cetmix_tower_server/models/cx_tower_plan.py
Auto-merging cetmix_tower_server/models/cx_tower_variable.py
Auto-merging cetmix_tower_server/models/cx_tower_variable_value.py
CONFLICT (content): Merge conflict in cetmix_tower_server/models/cx_tower_variable_value.py
Auto-merging cetmix_tower_server/views/cx_tower_command_view.xml
Auto-merging cetmix_tower_server/views/cx_tower_file_template_view.xml
Auto-merging cetmix_tower_server/views/cx_tower_plan_view.xml
Auto-merging cetmix_tower_server/views/cx_tower_server_view.xml
CONFLICT (content): Merge conflict in cetmix_tower_server/views/cx_tower_server_view.xml
Auto-merging cetmix_tower_server/views/cx_tower_variable_value_view.xml
Auto-merging cetmix_tower_server/views/cx_tower_variable_view.xml
error: could not apply 16e5a68... [IMP] cetmix_tower_server: A record may be readonly and gray in lists
hint: Resolve all conflicts manually, mark them as resolved with
hint: "git add/rm <conflicted_files>", then run "git rebase --continue".
hint: You can instead skip this commit: run "git rebase --skip".
hint: To abort and get back to the state before "git rebase", run "git rebase --abort".
Could not apply 16e5a68... [IMP] cetmix_tower_server: A record may be readonly and gray in lists

norlinhenrik commented 1 week ago

@Aldeigja I have fixed the conflicts. When I push, I get an access error. Do I still have access to push to cetmix-tower?

ivs-cetmix commented 1 week ago

@norlinhenrik this repo is now public so you should fork it and open a new PR directly from your fork.

cetmix / cetmix-tower

[14.0][IMP] cetmix_tower_server: 'readonly' field, many2one restrict, shared cmd/plans #65