Support 5.18.0+ kernels

[JamesRHarris]

SUBDIRS has been deprecated, switched to M= refer to Documentation/kbuild/modules.txt 2.6.34.14

[ooshlablu]

I give this a :+1: , I ran into the same exact issues earlier today. Kernel 5.4

[ooshlablu]

Been over a year, but I can confirm that this works on Kernel 5.11 also.

[jmcevoy]

I tried building this PR on Fedora 36 and it built with warnings in memcpy. I installed the module and started mythTVbackend and watching LiveTV crashed my workstation requiring that I hit the reset button. Output from make:

[jmcevoy@phenom infinitv_pcie]$ make make[1]: Entering directory '/usr/src/kernels/5.18.16-200.fc36.x86_64' CC [M] /home/jmcevoy/git2/infinitv_pcie/ctn91xx_driver.o CC [M] /home/jmcevoy/git2/infinitv_pcie/ctn91xx_interrupt.o CC [M] /home/jmcevoy/git2/infinitv_pcie/ctn91xx_ioctl.o CC [M] /home/jmcevoy/git2/infinitv_pcie/ctn91xx_util.o CC [M] /home/jmcevoy/git2/infinitv_pcie/ctn91xx_event.o CC [M] /home/jmcevoy/git2/infinitv_pcie/ctn91xx_mpeg.o CC [M] /home/jmcevoy/git2/infinitv_pcie/ctn91xx_net.o CC [M] /home/jmcevoy/git2/infinitv_pcie/ctn91xx_reset.o CC [M] /home/jmcevoy/git2/infinitv_pcie/ctn91xx_rpc.o CC [M] /home/jmcevoy/git2/infinitv_pcie/ctn91xx_pci.o CC [M] /home/jmcevoy/git2/infinitv_pcie/ctn91xx_rtp.o In file included from ./include/linux/string.h:253, from ./include/linux/bitmap.h:11, from ./include/linux/cpumask.h:12, from ./arch/x86/include/asm/cpumask.h:5, from ./arch/x86/include/asm/msr.h:11, from ./arch/x86/include/asm/processor.h:22, from ./arch/x86/include/asm/timex.h:5, from ./include/linux/timex.h:67, from ./include/linux/time32.h:13, from ./include/linux/time.h:60, from ./include/linux/stat.h:19, from ./include/linux/module.h:13, from /home/jmcevoy/git2/infinitv_pcie/ctn91xx_kal.h:6, from /home/jmcevoy/git2/infinitv_pcie/ctn91xx.h:109, from /home/jmcevoy/git2/infinitv_pcie/ctn91xx_net.h:4, from /home/jmcevoy/git2/infinitv_pcie/ctn91xx_net.c:1: /home/jmcevoy/git2/infinitv_pcie/ctn91xx_net.c: In function ‘ctn91xx_net_set_mac_addr’: /home/jmcevoy/git2/infinitv_pcie/ctn91xx_net.c:124:18: warning: passing argument 1 of ‘__builtin_memcpy’ discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers] 124 | memcpy(netdev->dev_addr, addr->sa_data, netdev->addr_len); | ~~~~~~^~~~~~~~~~ ./include/linux/fortify-string.h:362:27: note: in definition of macro ‘__fortify_memcpy_chk’ 362 | __underlying_##op(p, q, __fortify_size); \ | ^ /home/jmcevoy/git2/infinitv_pcie/ctn91xx_net.c:124:5: note: in expansion of macro ‘memcpy’ 124 | memcpy(netdev->dev_addr, addr->sa_data, netdev->addr_len); | ^~~~~~ /home/jmcevoy/git2/infinitv_pcie/ctn91xx_net.c:124:18: note: expected ‘void *’ but argument is of type ‘const unsigned char *’ 124 | memcpy(netdev->dev_addr, addr->sa_data, netdev->addr_len); | ~~~~~~^~~~~~~~~~ ./include/linux/fortify-string.h:362:27: note: in definition of macro ‘__fortify_memcpy_chk’ 362 | __underlying_##op(p, q, __fortify_size); \ | ^ /home/jmcevoy/git2/infinitv_pcie/ctn91xx_net.c:124:5: note: in expansion of macro ‘memcpy’ 124 | memcpy(netdev->dev_addr, addr->sa_data, netdev->addr_len); | ^~~~~~ LD [M] /home/jmcevoy/git2/infinitv_pcie/ctn91xx.o MODPOST /home/jmcevoy/git2/infinitv_pcie/Module.symvers CC [M] /home/jmcevoy/git2/infinitv_pcie/ctn91xx.mod.o LD [M] /home/jmcevoy/git2/infinitv_pcie/ctn91xx.ko BTF [M] /home/jmcevoy/git2/infinitv_pcie/ctn91xx.ko Skipping BTF generation for /home/jmcevoy/git2/infinitv_pcie/ctn91xx.ko due to unavailability of vmlinux make[1]: Leaving directory '/usr/src/kernels/5.18.16-200.fc36.x86_64'

[sgreene820]

Same issues as I had with the base branch, I have secure boot disabled, but it is still failing make install because of the lack of signing keys.

make[1]: Entering directory '/usr/src/linux-headers-5.15.0-58-generic' arch/x86/Makefile:142: CONFIG_X86_X32 enabled but no binutils support INSTALL /lib/modules/5.15.0-58-generic/extra/ctn91xx.ko SIGN /lib/modules/5.15.0-58-generic/extra/ctn91xx.ko At main.c:160:

• SSL error:FFFFFFFF80000002:system library::No such file or directory: ../crypto/bio/bss_file.c:67
• SSL error:10000080:BIO routines::no such file: ../crypto/bio/bss_file.c:75 sign-file: certs/signing_key.pem: No such file or directory DEPMOD /lib/modules/5.15.0-58-generic

What am I missing here? I thought it would bypass asking for signing keys with secure boot disabled.

[JamesRHarris]

Same issues as I had with the base branch, I have secure boot disabled, but it is still failing make install because of the lack of signing keys.

make[1]: Entering directory '/usr/src/linux-headers-5.15.0-58-generic' arch/x86/Makefile:142: CONFIG_X86_X32 enabled but no binutils support INSTALL /lib/modules/5.15.0-58-generic/extra/ctn91xx.ko SIGN /lib/modules/5.15.0-58-generic/extra/ctn91xx.ko At main.c:160:

• SSL error:FFFFFFFF80000002:system library::No such file or directory: ../crypto/bio/bss_file.c:67
• SSL error:10000080:BIO routines::no such file: ../crypto/bio/bss_file.c:75 sign-file: certs/signing_key.pem: No such file or directory DEPMOD /lib/modules/5.15.0-58-generic

What am I missing here? I thought it would bypass asking for signing keys with secure boot disabled.

This seems to be a local kernel config issue. You might want to review https://www.kernel.org/doc/Documentation/admin-guide/module-signing.rst

[sgreene820]

I'm sure you're right, but here's the thing: I'm using a stock kernel. I haven't kept up since secure boot started being enforced in v5.x, which basically killed my Ceton card for mythtv. I'm not running dual boot, and this box is just a dedicated secondary Myth backend, so I disabled Secure Boot, but it's still pestering me for setting change but giving me no help as to what changes and where.

Steve Greene (301) 842-8923 historicity.co An independent archival professional specializing in still photography, moving images and recorded sound.

On Fri, Jan 27, 2023 at 3:08 PM James Harris @.***> wrote:

Same issues as I had with the base branch, I have secure boot disabled, but it is still failing make install because of the lack of signing keys.

make[1]: Entering directory '/usr/src/linux-headers-5.15.0-58-generic' arch/x86/Makefile:142: CONFIG_X86_X32 enabled but no binutils support INSTALL /lib/modules/5.15.0-58-generic/extra/ctn91xx.ko SIGN /lib/modules/5.15.0-58-generic/extra/ctn91xx.ko At main.c:160:

• SSL error:FFFFFFFF80000002:system library::No such file or directory: ../crypto/bio/bss_file.c:67
• SSL error:10000080:BIO routines::no such file: ../crypto/bio/bss_file.c:75 sign-file: certs/signing_key.pem: No such file or directory DEPMOD /lib/modules/5.15.0-58-generic

What am I missing here? I thought it would bypass asking for signing keys with secure boot disabled.

This seems to be a local kernel config issue. You might want to review https://www.kernel.org/doc/Documentation/admin-guide/module-signing.rst

— Reply to this email directly, view it on GitHub https://github.com/ceton/infinitv_pcie/pull/13#issuecomment-1407022759, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASQW2SY5GHCKIAPLPASUKRTWUQTKPANCNFSM4KEBI3AQ . You are receiving this because you commented.Message ID: @.***>

[sgreene820]

I think I may have reinstalled as legacy as an attempt to get around the cert keys issue.

mokutil -sb status returns "EFI variables are not supported on this system"

Why is the driver compilation still checking for keys?

Steve

Steve Greene (301) 842-8923 historicity.co An independent archival professional specializing in still photography, moving images and recorded sound.

On Fri, Jan 27, 2023 at 5:22 PM Steve Greene @.***> wrote:

I'm sure you're right, but here's the thing: I'm using a stock kernel. I haven't kept up since secure boot started being enforced in v5.x, which basically killed my Ceton card for mythtv. I'm not running dual boot, and this box is just a dedicated secondary Myth backend, so I disabled Secure Boot, but it's still pestering me for setting change but giving me no help as to what changes and where.

Steve Greene (301) 842-8923 historicity.co An independent archival professional specializing in still photography, moving images and recorded sound.

On Fri, Jan 27, 2023 at 3:08 PM James Harris @.***> wrote:

Same issues as I had with the base branch, I have secure boot disabled, but it is still failing make install because of the lack of signing keys.

make[1]: Entering directory '/usr/src/linux-headers-5.15.0-58-generic' arch/x86/Makefile:142: CONFIG_X86_X32 enabled but no binutils support INSTALL /lib/modules/5.15.0-58-generic/extra/ctn91xx.ko SIGN /lib/modules/5.15.0-58-generic/extra/ctn91xx.ko At main.c:160:

• SSL error:FFFFFFFF80000002:system library::No such file or directory: ../crypto/bio/bss_file.c:67
• SSL error:10000080:BIO routines::no such file: ../crypto/bio/bss_file.c:75 sign-file: certs/signing_key.pem: No such file or directory DEPMOD /lib/modules/5.15.0-58-generic

What am I missing here? I thought it would bypass asking for signing keys with secure boot disabled.

This seems to be a local kernel config issue. You might want to review https://www.kernel.org/doc/Documentation/admin-guide/module-signing.rst

— Reply to this email directly, view it on GitHub https://github.com/ceton/infinitv_pcie/pull/13#issuecomment-1407022759, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASQW2SY5GHCKIAPLPASUKRTWUQTKPANCNFSM4KEBI3AQ . You are receiving this because you commented.Message ID: @.***>