search

cevoaustralia / aws-google-auth

Provides AWS STS credentials based on Google Apps SAML SSO auth (what a jumble!)
MIT License
537 stars 181 forks source link

fix display of captcha url while neither xv or display utility are available #105

Closed JeremJR closed 5 years ago

JeremJR commented 6 years ago

see https://github.com/cevoaustralia/aws-google-auth/pull/91#issuecomment-413438202

https://pillow.readthedocs.io/en/5.2.x/handbook/tutorial.html

The standard version of show() is not very efficient, since it saves the image to a temporary file and calls the xv utility to display the image. If you don’t have xv installed, it won’t even work. When it does work though, it is very handy for debugging and tests.

https://pillow.readthedocs.io/en/5.2.x/reference/Image.html#PIL.Image.Image.show

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.1%) to 45.767% when pulling b19acf5acda7794e13195152c0ed8b9ab8f53125 on JeremJR:fix/display_captcha_url into 519ddfb33a09af7782f27341d4609a778ffaf29a on cevoaustralia:master.

JeremJR commented 6 years ago

The docker build test failure seems related to this issue https://github.com/gliderlabs/docker-alpine/issues/433

tnguyen1 commented 5 years ago

I think you should rebase this change on aws-google-auth 0.0.27 or master.

JeremJR commented 5 years ago

@tnguyen1 I don't understand your point, https://github.com/JeremJR/aws-google-auth/tree/fix/display_captcha_url is 1 commit ahead of cevoaustralia:master.

Colgaton commented 5 years ago

Is this going to be pushed to master? I'm in windows 10 and I don't get the picture nor the url either. edit: I wasn't clear, I'm using cygwin.

joshuatalb commented 5 years ago

I created and pushed a Docker image which contains a fix to my Docker Hub. You can pull it down from joshuatalb/aws-google-auth:v0.0.28. The script will now provide you with a link to view the captcha, subsequently allowing access via Google Auth.

stevemac007 commented 5 years ago

Sorry for the radio silence, things have been busy recently - taking a look at the PR's raised over the past few weeks.

This looks good, but as per #112 we probably should always print the captcha URL in case the image fails.

JeremJR commented 5 years ago

Great, any idea about the date of the next release that will include https://github.com/cevoaustralia/aws-google-auth/pull/112 ?

stevemac007 commented 5 years ago

I'm hoping to validate it all and push the next release in the next 24hrs, hopefully sooner if it all works as expected.

Just trying to validate the scenario on windows.

stevemac007 commented 5 years ago

As hoped - Pillow seems to work on Windows too - so we should refactor this to only check for the executables on posix, but let it open the file on windows - at least until someone has a better idea.

stevemac007 commented 5 years ago

It seems that my Google account doesn't need a Captcha at the moment, so I'll do some testing of the image snippets across the operating systems I have access to.

stevemac007 commented 5 years ago

Whitespace issues are mine, I'll merge and fix on master.. :ducks:

JeremJR commented 5 years ago

Thank you!

stevemac007 commented 5 years ago

So this also seems to break OSX - I've excluded darwin