Closed JeremJR closed 5 years ago
The docker build test failure seems related to this issue https://github.com/gliderlabs/docker-alpine/issues/433
I think you should rebase this change on aws-google-auth 0.0.27 or master.
@tnguyen1 I don't understand your point, https://github.com/JeremJR/aws-google-auth/tree/fix/display_captcha_url is 1 commit ahead of cevoaustralia:master.
Is this going to be pushed to master? I'm in windows 10 and I don't get the picture nor the url either. edit: I wasn't clear, I'm using cygwin.
I created and pushed a Docker image which contains a fix to my Docker Hub. You can pull it down from joshuatalb/aws-google-auth:v0.0.28
. The script will now provide you with a link to view the captcha, subsequently allowing access via Google Auth.
Sorry for the radio silence, things have been busy recently - taking a look at the PR's raised over the past few weeks.
This looks good, but as per #112 we probably should always print the captcha URL in case the image fails.
Great, any idea about the date of the next release that will include https://github.com/cevoaustralia/aws-google-auth/pull/112 ?
I'm hoping to validate it all and push the next release in the next 24hrs, hopefully sooner if it all works as expected.
Just trying to validate the scenario on windows.
As hoped - Pillow
seems to work on Windows too - so we should refactor this to only check for the executables on posix
, but let it open the file on windows - at least until someone has a better idea.
It seems that my Google account doesn't need a Captcha at the moment, so I'll do some testing of the image snippets across the operating systems I have access to.
Whitespace issues are mine, I'll merge and fix on master.. :ducks:
Thank you!
So this also seems to break OSX - I've excluded darwin
see https://github.com/cevoaustralia/aws-google-auth/pull/91#issuecomment-413438202
https://pillow.readthedocs.io/en/5.2.x/handbook/tutorial.html
https://pillow.readthedocs.io/en/5.2.x/reference/Image.html#PIL.Image.Image.show