cevoaustralia / aws-google-auth

Provides AWS STS credentials based on Google Apps SAML SSO auth (what a jumble!)

MIT License

537 stars 181 forks source link

Don't attempt to open CAPTCHA image when inside docker #109

Closed mafrosis closed 5 years ago

mafrosis commented 5 years ago

I was running your tool in Docker and was prompted for a Captcha..

coveralls commented 5 years ago

Coverage decreased (-0.05%) to 45.575% when pulling a149920a8bde87d3be53cc3cdb050700a4b1d84d on mafrosis:captcha-in-docker into 519ddfb33a09af7782f27341d4609a778ffaf29a on cevoaustralia:master.

mafrosis commented 5 years ago

105 is a more general solution to this problem, but this quick hack did it for me

stevemac007 commented 5 years ago

Sorry for the radio silence, things have been busy recently - taking a look at the PR's raised over the past few weeks.

I'll look at getting #105 in so that we don't need this version.

stevemac007 commented 5 years ago

Released 0.0.28 with a fix that does the same thing - if you feel there are more cases, please update the issue or push a new PR.