search

cevoaustralia / aws-google-auth

Provides AWS STS credentials based on Google Apps SAML SSO auth (what a jumble!)
MIT License
537 stars 181 forks source link

Always display CAPTCHA url #112

Closed fenak closed 5 years ago

fenak commented 5 years ago

See #111

I think #105 still needs to be implemented as we probably shouldn't call xv in an environment where it won't be available, but even with that I believe it's better to always show the CAPTCHA url, as it solves two things:

coveralls commented 5 years ago

Coverage Status

Coverage decreased (-0.06%) to 45.563% when pulling 331134eebd1883b2e50c5c19848018a1d4f14782 on fenak:always-display-captcha-url into 519ddfb33a09af7782f27341d4609a778ffaf29a on cevoaustralia:master.

coveralls commented 5 years ago

Coverage Status

Coverage decreased (-0.06%) to 45.563% when pulling 331134eebd1883b2e50c5c19848018a1d4f14782 on fenak:always-display-captcha-url into 519ddfb33a09af7782f27341d4609a778ffaf29a on cevoaustralia:master.

coveralls commented 5 years ago

Coverage Status

Coverage decreased (-0.06%) to 45.563% when pulling 331134eebd1883b2e50c5c19848018a1d4f14782 on fenak:always-display-captcha-url into 519ddfb33a09af7782f27341d4609a778ffaf29a on cevoaustralia:master.

stevemac007 commented 5 years ago

Sorry for the radio silence, things have been busy recently - taking a look at the PR's raised over the past few weeks.

This one looks good - probably will invalidate some other changes, so we'll have to merge in the similar issues.

There is obviously lots of captcha usage these days - for some reason mine has just gone away again, so makes it hard to test this in practice.