search

cevoaustralia / aws-google-auth

Provides AWS STS credentials based on Google Apps SAML SSO auth (what a jumble!)
MIT License
537 stars 181 forks source link

add --quiet option #124

Closed johnnyplaydrums closed 5 years ago

johnnyplaydrums commented 5 years ago

Hello there! I mentioned the idea of adding a --quiet flag in this github issue: https://github.com/cevoaustralia/aws-google-auth/issues/123. @stevemac007 seemed into so I went ahead and gave it a shot! Ran all tests locally with pytest and they all pass.

The only thing I'm trying to figure out is how to quiet the message Failed to import U2F libraries... here. Since it's imported before the Google class is instantiated, we don't have access to the config object. One option would be to put the import statement in the __init__ function for the Google class, but that seems weird to me? idk. Let me know what you think about that. Thank you! I'm also not sure this message is needed since this package explicitly supports using U2F or not, and gives users options for how to install with or without. Open to any ideas tho!

coveralls commented 5 years ago

Coverage Status

Coverage increased (+0.09%) to 45.785% when pulling 28fab528daa494a7e839b2a0b3b0573db03dcfe9 on johnplaydrums:add-quiet-option into 0a5452693374ec235f079ba13065f3a864f2c287 on cevoaustralia:master.

coveralls commented 5 years ago

Coverage Status

Coverage increased (+0.09%) to 45.785% when pulling 28fab528daa494a7e839b2a0b3b0573db03dcfe9 on johnplaydrums:add-quiet-option into 0a5452693374ec235f079ba13065f3a864f2c287 on cevoaustralia:master.

johnnyplaydrums commented 5 years ago

Happy to merge this in as is, any thoughts on the Failed to import U2F libraries... print statement here? Not sure the best way to suppress that.

johnnyplaydrums commented 5 years ago

Hey all, checking in on this one. Can we merge it in? Thank you!

stevemac007 commented 5 years ago

Happy New Year @johnplaydrums - I'm back from break today will take a look at getting this merged and released soon.

johnnyplaydrums commented 5 years ago

Yay thank you @stevemac007, and welcome back! I got more prs coming your way 😄