Closed johnnyplaydrums closed 5 years ago
Happy to merge this in as is, any thoughts on the Failed to import U2F libraries...
print statement here? Not sure the best way to suppress that.
Hey all, checking in on this one. Can we merge it in? Thank you!
Happy New Year @johnplaydrums - I'm back from break today will take a look at getting this merged and released soon.
Yay thank you @stevemac007, and welcome back! I got more prs coming your way 😄
Hello there! I mentioned the idea of adding a
--quiet
flag in this github issue: https://github.com/cevoaustralia/aws-google-auth/issues/123. @stevemac007 seemed into so I went ahead and gave it a shot! Ran all tests locally withpytest
and they all pass.The only thing I'm trying to figure out is how to quiet the message
Failed to import U2F libraries...
here. Since it's imported before theGoogle
class is instantiated, we don't have access to theconfig
object. One option would be to put the import statement in the__init__
function for theGoogle
class, but that seems weird to me? idk. Let me know what you think about that. Thank you! I'm also not sure this message is needed since this package explicitly supports using U2F or not, and gives users options for how to install with or without. Open to any ideas tho!