Closed mfulleratlassian closed 5 years ago
Looking deeper at this today looks like there are a few things preventing me using this directly.
@mfulleratlassian - I had not seen cloudtoken, will take a look - is there anything specific that was blocking your use of this?
Most of your functions perform a lot of individual things. If you would be happy for me to create a PR that splits out the steps into more functions I could use your package directly. For now I have forked this codebase to create a plugin to cloudtoken, but ideally we can use your package directly and leave the good work you have done in one spot.
I'd be very happy with more functional breakdown, will make the testing much easier.
Hey Cevo,
My team at Atlassian have a similar open source tool called CloudToken: https://bitbucket.org/atlassian/cloudtoken
It provides IdP based auth to AWS via pluggable providers. We would like to use aws-google-auth inside a plugin to allow Google support, however in order to do that we need to split out the google and aws interactions inside the process_auth() from init.py.
This PR just splits them into two methods that are called via the process_auth() method.
If you are happy for this change we can implement a google plugin using your module.
Thanks Mike