search

cevoaustralia / aws-google-auth

Provides AWS STS credentials based on Google Apps SAML SSO auth (what a jumble!)
MIT License
537 stars 181 forks source link

Split out Google and AWS calls in process_auth() #125

Closed mfulleratlassian closed 5 years ago

mfulleratlassian commented 5 years ago

Hey Cevo,

My team at Atlassian have a similar open source tool called CloudToken: https://bitbucket.org/atlassian/cloudtoken

It provides IdP based auth to AWS via pluggable providers. We would like to use aws-google-auth inside a plugin to allow Google support, however in order to do that we need to split out the google and aws interactions inside the process_auth() from init.py.

This PR just splits them into two methods that are called via the process_auth() method.

If you are happy for this change we can implement a google plugin using your module.

Thanks Mike

coveralls commented 5 years ago

Coverage Status

Coverage increased (+0.4%) to 46.044% when pulling 8239dcea04ae28be893c86d9731831f6e4006cfb on mfulleratlassian:master into 0a5452693374ec235f079ba13065f3a864f2c287 on cevoaustralia:master.

coveralls commented 5 years ago

Coverage Status

Coverage increased (+0.4%) to 46.044% when pulling 8239dcea04ae28be893c86d9731831f6e4006cfb on mfulleratlassian:master into 0a5452693374ec235f079ba13065f3a864f2c287 on cevoaustralia:master.

mfulleratlassian commented 5 years ago

Looking deeper at this today looks like there are a few things preventing me using this directly.

stevemac007 commented 5 years ago

@mfulleratlassian - I had not seen cloudtoken, will take a look - is there anything specific that was blocking your use of this?

mfulleratlassian commented 5 years ago

Most of your functions perform a lot of individual things. If you would be happy for me to create a PR that splits out the steps into more functions I could use your package directly. For now I have forked this codebase to create a plugin to cloudtoken, but ideally we can use your package directly and leave the good work you have done in one spot.

stevemac007 commented 5 years ago

I'd be very happy with more functional breakdown, will make the testing much easier.