search

cevoaustralia / aws-google-auth

Provides AWS STS credentials based on Google Apps SAML SSO auth (what a jumble!)
MIT License
537 stars 181 forks source link

Add use of logging instead of print statements #127

Closed kriation closed 5 years ago

kriation commented 5 years ago

I had difficulty troubleshooting an issue I was experiencing using this utility, so I added logging, to be able to debug not only this code, but the use of its dependent libraries.

This is not feature complete, as I'm sure there is room for improvement but it provided the necessary functionality for me to successful diagnose and resolve my issue.

kriation commented 5 years ago

I'll work on adding tests for the additional argument over the weekend.

coveralls commented 5 years ago

Coverage Status

Coverage increased (+0.6%) to 46.41% when pulling 952dac235e3cfecd1a0eacaed27399243eaa950b on kriation:feature/logging into 801ccb79b036369f4accf394ba4e8086c454c685 on cevoaustralia:master.

coveralls commented 5 years ago

Coverage Status

Coverage increased (+0.6%) to 46.41% when pulling 952dac235e3cfecd1a0eacaed27399243eaa950b on kriation:feature/logging into 801ccb79b036369f4accf394ba4e8086c454c685 on cevoaustralia:master.

coveralls commented 5 years ago

Coverage Status

Coverage increased (+0.6%) to 46.41% when pulling 952dac235e3cfecd1a0eacaed27399243eaa950b on kriation:feature/logging into 801ccb79b036369f4accf394ba4e8086c454c685 on cevoaustralia:master.

coveralls commented 5 years ago

Coverage Status

Coverage increased (+0.6%) to 46.41% when pulling 952dac235e3cfecd1a0eacaed27399243eaa950b on kriation:feature/logging into 801ccb79b036369f4accf394ba4e8086c454c685 on cevoaustralia:master.

coveralls commented 5 years ago

Coverage Status

Coverage increased (+0.6%) to 46.41% when pulling 8b0361b060d6407359d789ea73ca5b61c5b094e8 on kriation:feature/logging into 801ccb79b036369f4accf394ba4e8086c454c685 on cevoaustralia:master.

brainstorm commented 5 years ago

Same here, I totally endorse this PR, can you please merge @cevoaustralia?

kriation commented 5 years ago

Hi @stevemac007, could you review and merge this PR? @brainstorm and I think this would be useful to add to the code base.

kriation commented 5 years ago

Looks good - and works well locally for me. I would like the error messages cleaned up - but I'll merge and fix this.

Thanks for the contribution - and sorry on the radio silence. My pleasure! Thank you for merging it into the code base.