cevoaustralia / aws-google-auth

Provides AWS STS credentials based on Google Apps SAML SSO auth (what a jumble!)
MIT License
537 stars 181 forks source link

PlainText keyring should not be enabled by default #131

Open danielkza opened 5 years ago

danielkza commented 5 years ago

Due to the inclusing of keyrings.alt as a dependency, the plain text keyring is loaded and included by default, which will mask issues when the real keyrings can't be used (such as a missing Dbus dependency in Linux).

Given the sensitive nature of the secrets aws-google-auth handles, it should not ever enable the plain text keyring. See https://github.com/jaraco/keyring/issues/370 for some reasons why upstream doesn't want to do it, but even then. it should be handled internally in this project.