search

cevoaustralia / aws-google-auth

Provides AWS STS credentials based on Google Apps SAML SSO auth (what a jumble!)
MIT License
538 stars 180 forks source link

Add more information about the default duration CLI argument #143

Closed calvinhughes closed 4 years ago

calvinhughes commented 5 years ago

I think the current command line args for duration aren't too clear, as the default duration we set to 12h which is higher than the default. So this hints towards that on the CLI argument, and also makes it more clear on the README

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 46.699% when pulling 3e16b433c2c496028a7349d5a7249d3a0ba90754 on calvinhughes:add-explanation-for-default-duration-argument into e468c011068b386375b8ecb686323bf69e503633 on cevoaustralia:master.

stevemac007 commented 5 years ago

Thats a good pickup - I didn't realise we were setting that out to 12hrs.

stevemac007 commented 5 years ago

I would have expected us to use the role default if one was not supplied - I'll take a look at the impact of making that change.

stevemac007 commented 5 years ago

Looks like this was changed with #66.