Add support for parallel authentications

cevoaustralia / aws-google-auth

Provides AWS STS credentials based on Google Apps SAML SSO auth (what a jumble!)

MIT License

537 stars 181 forks source link

Add support for parallel authentications #173

Closed ventsislav-georgiev closed 4 years ago

ventsislav-georgiev commented 4 years ago

Login to multiple locations by running the cli in parallel. Fixes an issue where concurrent read and writes of the config end up breaking it or overwriting credentials.

Changes:

Use a filelock lib for cross-process locking of read/write config operations

coveralls commented 4 years ago

Coverage decreased (-0.2%) to 48.941% when pulling 501620cdd8bdf14f558577915b1e0616b2e2e4f2 on ventsislav-georgiev:multi-process into b5ee2478b04e3f5db8777e201663635006fcf93b on cevoaustralia:master.

ventsislav-georgiev commented 4 years ago

@stevemac007 This is a minor change (check it with whitespace diff disable e.g. &w=1), with a single small dependency install. The coverage is falling because these existing branches do not have tests. My change just adds an inter-process locking via new file. It shouldn't have any affect to the ppl which do not span multiple processes and fix the concurrency issues for those that do.

gprodanov commented 4 years ago

I could really make use of this feature.