Sort the list of roles when they're presented for selection

cevoaustralia / aws-google-auth

Provides AWS STS credentials based on Google Apps SAML SSO auth (what a jumble!)

MIT License

537 stars 181 forks source link

Sort the list of roles when they're presented for selection #198

Open RonRothman opened 3 years ago

RonRothman commented 3 years ago

The main benefit is that lexicographically similar roles (e.g. same AWS account) will be adjacent, reducing errors. For example, what is currently presented this way:

[  1] arn:aws:iam::13856293331:role/admin
[  2] arn:aws:iam::20922837461:role/admin
[  3] arn:aws:iam::13856293331:role/eng/dev

would be presented this way:

[  2] arn:aws:iam::20922837461:role/admin
[  1] arn:aws:iam::13856293331:role/admin
[  3] arn:aws:iam::13856293331:role/eng/dev

coveralls commented 3 years ago

Coverage remained the same at 47.536% when pulling cbc96d77c09a3ec6d6bfe143e15735d1c7281a25 on RonRothman:sort_roles_prompt into d473d67b0772700942f5bb0db3522af0a1005453 on cevoaustralia:master.