search

cevoaustralia / aws-google-auth

Provides AWS STS credentials based on Google Apps SAML SSO auth (what a jumble!)
MIT License
537 stars 179 forks source link

Python 3.5 deprecation warnings using docker container #218

Open ernestm opened 3 years ago

ernestm commented 3 years ago

When using the cevoaustralia/aws-google-auth docker container to auth to AWS using google, the following messages have begun to appear:

/usr/lib/python3.5/site-packages/secretstorage/dhcrypto.py:16: CryptographyDeprecationWarning: Python 3.5 support will be dropped in the next release of cryptography. Please upgrade your Python.

/usr/lib/python3.5/site-packages/boto3/compat.py:94: PythonDeprecationWarning: Boto3 will no longer support Python 3.5 starting February 1, 2021. To continue receiving service updates, bug fixes, and security updates please upgrade to Python 3.6 or later. More information can be found here: https://aws.amazon.com/blogs/developer/announcing-the-end-of-support-for-python-3-4-and-3-5-in-the-aws-sdk-for-python-and-aws-cli-v1/ warnings.warn(warning, PythonDeprecationWarning)

alongwill commented 2 years ago

I tested this change to the Dockerfile which worked for me:

-FROM alpine:3.5
+FROM alpine:3.15.0
...
-RUN pip3 install -r /build/requirements.txt
+RUN pip3 install --upgrade pip && pip3 install -r /build/requirements.txt

As a side note also had to set the timezone via TZ env var to avoid tzlocal complaining it wasn't set.

export TZ=UTC
docker run -it -e GOOGLE_USERNAME \
  -e GOOGLE_IDP_ID -e GOOGLE_SP_ID \
  -e AWS_PROFILE -e ROLE_ARN -e TZ \
  -v ~/.aws:/root/.aws alongwill/aws-google-auth \
  --region eu-west-1 -d 28800
sbbowers commented 2 years ago

3.6 is already end-of-life. I've been using aws-google-auth on python 3.9 with no issues for awhile. Could we consider using a base of python:3.9-alpine or testing it against python:3.10-alpine?