cevoaustralia / aws-google-auth

Provides AWS STS credentials based on Google Apps SAML SSO auth (what a jumble!)
MIT License
538 stars 180 forks source link

Add bg_response in request payload to passwd challenge #250

Closed ezeqme closed 2 years ago

ezeqme commented 2 years ago

This fix resolves the issue reported on https://github.com/cevoaustralia/aws-google-auth/issues/248

When adding the --bg-response parameter, the value is not passed on in the captcha validation request, which causes a validation error.

The error occurs because google blocks the request in new installations due to the default value that informs that there is no support for javascript "bg_response" with value "js_disabled".

It is necessary to pass the value as "bg_response" with value "js_enabled" to avoid the error in the google authentication flow.

But the error continues to occur in the captcha validation because this parameter was not passed on in the challenge response payload.

By adding "bg_response" with value "js_enabled" in the challenge submission, the authentication flow proceeds normally.

This error occurs in new installations of aws-google-auth, not being reproduced in installations that already existed, I can't explain why.

pichouk commented 2 years ago

Fixes the issue for me too. Thanks a lot @ezequielsbarros Now the question is : who have write access to this repository and to PyPI ? Because the last merge / release is from 15 months ago :grimacing:

gurumaia commented 2 years ago

Fixes our problem as well. @stevemac007 can you get this approved?

jindriago-scf commented 2 years ago

Hi team, is there something we can do to help merge this PR? This solves the problem some of our engineers are having deploying to AWS.

ezequielbarros commented 2 years ago

Hi team, is there something we can do to help merge this PR? This solves the problem some of our engineers are having deploying to AWS.

Temporarily while this PR is not merged I have locally altered the google.py file including the two lines of code from the commit of this PR. You can direct your engineers to do the same to temporarily fix the problem.

luizliso commented 2 years ago

Now it wokrs! Thanks @ezequielbarros

jeanmercierswile commented 2 years ago

It has worked for me. 👍

akours commented 2 years ago

Works like a charm! :+1:

rdonkin-attest commented 2 years ago

We are getting this issue a lot - this PR worked for several people to fix.

Hope this can be merged soon!

mrmooon commented 2 years ago

In the meantime, while this PR gets merged, we've been able to workaround this using the Docker image, which is still working (at least for most people in our team).

LeandroMReis commented 2 years ago

Worked perfectly. Thanks @ezequielbarros

LeandroMReis commented 2 years ago

@stevemac007

igorGevaerd commented 2 years ago

It worked like a charm!

yh0an commented 2 years ago

It works thanks ❤️

jonathanmdr commented 2 years ago

It works! Thanks @ezequielsbarros

KlavsKlavsen commented 2 years ago

Soo missing a maintainer here :(

dienp commented 2 years ago

Please merge

pichouk commented 2 years ago

Hi everyone :) As you can all see this project is not maintained anymore. So I'm pretty sure that adding new approvals, "+1", or whatever will not result in anything else than sending annoying notification to everyone :wink:

If someone have the time/energy to maintain a fork, or to reach a maintainer (or someone at Cevo Australia) in order to get write access to this project and to PyPi, it could be great. But I suggest to discuss this on a dedicated Github issue or on https://github.com/cevoaustralia/aws-google-auth/issues/238. Because I don't think this PR will be merged and release with the current situation.

danmoz commented 2 years ago

I see we got it merged, and even a new release on PyPI -- thanks to all involved!

One last thing, does anyone have access to push an updated image to Dockerhub?

I've built and pushed up my own version at danmorrison/aws-google-auth... but I'd sure prefer to be using the "official" one.