Fix bug (#22) to prevent AWS configuration corruption

cevoaustralia / aws-google-auth

Provides AWS STS credentials based on Google Apps SAML SSO auth (what a jumble!)

MIT License

538 stars 179 forks source link

Fix bug (#22) to prevent AWS configuration corruption #32

Closed mide closed 6 years ago

mide commented 6 years ago

This fixes #22, a bug that caused the AWS credentials to become corrupted by inserting a [None] section into the configuration. Since it doesn't make sense to write to a saved profile if one isn't set, it will just export instead.

tjbaker commented 6 years ago

If profile is not specified I'd think it would be [default]

mide commented 6 years ago

@tjbaker I'd be fine with setting that to be the default, but I'd fear it could override someone's [default] if they weren't aware. But I guess anyone running this could expect that. I'll make that change.

mide commented 6 years ago

I've opened #34 as a clean PR of this. There were a handful of recent merges and instead of making a mess of things by rebasing, I just created a new PR.