Fix bug (#22) to prevent AWS configuration corruption - Githubissues

cevoaustralia / aws-google-auth

Provides AWS STS credentials based on Google Apps SAML SSO auth (what a jumble!)

MIT License

538 stars 179 forks source link

Fix bug (#22) to prevent AWS configuration corruption #34

Closed mide closed 6 years ago

mide commented 6 years ago

This fixes #22 (replaces PR #32), a bug that caused the AWS credentials to become corrupted by inserting a [None] section into the configuration. Since it doesn't make sense to write to a saved profile if one isn't set, it will just export instead.

It's likely the case people will have [default] in use, so to prevent clobbering we'll default to sts instead. Of course, if the user wants to specify a profile they can. The profile [sts] was chosen based on the aws_role_credentials project.

Before this patch, if someone ran this script with no profile, the~/.aws/(config|credentials) would not have been modified.
After this patch, the AWS config will be updated.

coveralls commented 6 years ago

Coverage remained the same at 32.25% when pulling 1203344a9c5a2390ee9d6e83771b3c6f713a2662 on mide:no-profile-issue into 805277e87dc7b621b1b3a7bbd236dbf632d2d240 on cevoaustralia:master.

coveralls commented 6 years ago

Coverage remained the same at 32.25% when pulling 1203344a9c5a2390ee9d6e83771b3c6f713a2662 on mide:no-profile-issue into 805277e87dc7b621b1b3a7bbd236dbf632d2d240 on cevoaustralia:master.

coveralls commented 6 years ago

Coverage remained the same at 32.25% when pulling 1203344a9c5a2390ee9d6e83771b3c6f713a2662 on mide:no-profile-issue into 805277e87dc7b621b1b3a7bbd236dbf632d2d240 on cevoaustralia:master.

coveralls commented 6 years ago

Coverage remained the same at 32.25% when pulling 3dfc19fceb954c8c46b4b73345b566bbcb7043e2 on mide:no-profile-issue into 805277e87dc7b621b1b3a7bbd236dbf632d2d240 on cevoaustralia:master.

coveralls commented 6 years ago

Coverage increased (+0.09%) to 32.338% when pulling 9b9ce8495c6fd62e37099acd17a11c0ccf6e2877 on mide:no-profile-issue into 805277e87dc7b621b1b3a7bbd236dbf632d2d240 on cevoaustralia:master.

coveralls commented 6 years ago

Coverage increased (+0.09%) to 32.338% when pulling 9b9ce8495c6fd62e37099acd17a11c0ccf6e2877 on mide:no-profile-issue into 805277e87dc7b621b1b3a7bbd236dbf632d2d240 on cevoaustralia:master.

coveralls commented 6 years ago

Coverage increased (+0.09%) to 32.338% when pulling 9b9ce8495c6fd62e37099acd17a11c0ccf6e2877 on mide:no-profile-issue into 805277e87dc7b621b1b3a7bbd236dbf632d2d240 on cevoaustralia:master.

coveralls commented 6 years ago

Coverage increased (+0.09%) to 32.338% when pulling 9b9ce8495c6fd62e37099acd17a11c0ccf6e2877 on mide:no-profile-issue into 805277e87dc7b621b1b3a7bbd236dbf632d2d240 on cevoaustralia:master.

coveralls commented 6 years ago

Coverage remained the same at 32.338% when pulling c9795cf83fc57959a15b656b47872f5a3792ca12 on mide:no-profile-issue into bf48aa4630df48a28207539b4e1cfd2f87171090 on cevoaustralia:master.

coveralls commented 6 years ago

Coverage remained the same at 32.338% when pulling c9795cf83fc57959a15b656b47872f5a3792ca12 on mide:no-profile-issue into bf48aa4630df48a28207539b4e1cfd2f87171090 on cevoaustralia:master.

mide commented 6 years ago

Sorry to be a pain - But any idea when we could get this merged? This is blocking my team from switching to this tool. Thanks!

coveralls commented 6 years ago

Coverage remained the same at 32.432% when pulling e135b214baea5a150e1ebe6f9fb6b2f7bd8daac9 on mide:no-profile-issue into eb991c78bf4e96c30add65f0520b281f916a31ad on cevoaustralia:master.