cevoaustralia / aws-google-auth

Provides AWS STS credentials based on Google Apps SAML SSO auth (what a jumble!)
MIT License
538 stars 180 forks source link

Usability: print credentials success message #45

Open tjbaker opened 6 years ago

tjbaker commented 6 years ago

I'd love to see a summary success message like the following:

https://github.com/ThoughtWorksInc/aws_role_credentials/blob/master/aws_role_credentials/actions.py#L27-L33

Related, this project prints an export statement though I wonder how often it is used. This project encourages the use of the profile best practice, so wonder why people need to export the vars.

mide commented 6 years ago

That's a very valid question. I think we could add a flag -e, --export to output only the export line, and by default print something more human friendly.

That would also make it easier to use this tool with other scripts:

...
$(aws-google-auth ...)
...

instead of

...
$(aws-google-auth ... | tail -n 1)
...
nonspecialist commented 6 years ago

yes, I added that because my initial workflow was to do something like eval $(aws-google-auth | grep export) (not exactly, but you get the idea). Having it an option flag would make this cleaner while retaining the functionality.