cevoaustralia / aws-google-auth

Provides AWS STS credentials based on Google Apps SAML SSO auth (what a jumble!)
MIT License
538 stars 180 forks source link

Add keyring support #55

Closed dalen closed 6 years ago

dalen commented 6 years ago

Add a --keyring option to fetch and store the password in the keyring. Depends on the keyring module.

stevemac007 commented 6 years ago

I've not see keyring before, does this use an operating system specific process for storing passwords? Like Keychain for OSX?

Is there any specific preconditions required for this module to work?

stevemac007 commented 6 years ago

It looks like there are a couple of format issues that would be great to be fixed before merging.

./aws_google_auth/__init__.py:167:9: E112 expected an indented block
./aws_google_auth/__init__.py:167:14: E999 IndentationError: expected an indented block

and actually, that looks like it caught a real error with indentation.

dalen commented 6 years ago

Ooops, I had some auto formatting turned on and then tried to commit only lines I had actually changed. Must have done some mistake selecting changes there, will fix.

The keyring module supports a bunch of backends and has plugin support if you want to roll your own backend: https://pypi.python.org/pypi/keyring

These recommended keyring backends are supported by the Python keyring lib:

  • Mac OS X Keychain
  • Freedesktop Secret Service (requires secretstorage)
  • KWallet (requires dbus)
  • Windows Credential Locker
coveralls commented 6 years ago

Coverage Status

Coverage increased (+1.07%) to 48.594% when pulling 39b23eafcf603a45fc452da41bc16bbddf5b5f89 on dalen:master into 7840706fb3b10dc45bcf829ff31c45d7e324e551 on cevoaustralia:master.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.5%) to 39.493% when pulling 06ba9674fb97484a83666d273fcb2e48bb4ab489 on dalen:master into c4dac37b8233d813da1570d8a1b32e249835c5c6 on cevoaustralia:master.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.5%) to 39.493% when pulling 06ba9674fb97484a83666d273fcb2e48bb4ab489 on dalen:master into c4dac37b8233d813da1570d8a1b32e249835c5c6 on cevoaustralia:master.

dalen commented 6 years ago

Great, thanks

stevemac007 commented 6 years ago

Released as part of 0.0.24