search

cevoaustralia / aws-google-auth

Provides AWS STS credentials based on Google Apps SAML SSO auth (what a jumble!)
MIT License
538 stars 179 forks source link

Added tests for config processing #58

Closed stevemac007 closed 6 years ago

stevemac007 commented 6 years ago

This is the last one for the night, and introduced a minor refactoring to test the config processing around the coalesce values for each parameter.

I expected this to just be another simple task of covering the existing codebase, but it fleshed out the fact that there is no way to override the boolean values with either the environment variables nor a stored config set.

This happens because the args parser will return either True or False (depending on config), and because the args fields are first, will always take precedence.

It may not be critical for these True/False flags, so I think we should look at each one and remove the ENV variable lookup..

Very interested in discussion on this one..

coveralls commented 6 years ago

Coverage Status

Coverage increased (+5.1%) to 45.155% when pulling 02a37659e8a2c79b262d2d4ed2b611d6387f4e76 on test-config-processing into c4dac37b8233d813da1570d8a1b32e249835c5c6 on master.

stevemac007 commented 6 years ago

Merging this all together as part of #63