Closed endorama closed 6 years ago
After Travis, there are some errors:
2.7.14
fail during flake8
checks for this reason:./aws_google_auth/util.py:92:30: E999 SyntaxError: invalid syntax
print(...)
with parenthesis is responsible, could you please help me in writing this compatible with python 2? Is possible that the print
function should be replaced entirely. I'm sorry I'm not an expert about python version differences.3.4
failed at installation step due to timeout3.5.5
and 3.6.3
fail during running test for this reason:FAIL: test_process_auth_dont_resolve_alias (aws_google_auth.tests.test_init.TestInit)
python setup.py test
and I also used coverage
as in the Travis build, but wasn't able to reproduce.Would be great if you could update the README with a section on using tty redirection as a way to feed the password into the tool.
I want to release all the recent merge requests, then we can look at the next version including this change.
@stevemac007 Readme updated as requested, please let me know if the phrasing is ok. Probably would be good to refer also to release number to make it easier to know since when this feature is available.
I like this PR as-is. I think it's a great contribution and I'm coming around to the idea that "it's not our job" to prevent people from shooting themselves in the foot (using echo "s3creT" | aws-google-auth ...
).
I have a few colleagues that have shared their desire to use their password manager CLI to interact with this tool, and that's anything but "shoot yourself in the foot" behavior.
Thanks a lot for merging this! :smiley:
Hello, this PR closes issue #82, providing implementation for getting password from stdin.
I extracted the
getpass.getpass
call in theUtil
module, fixed the tests and added two unit test for the new function:test_get_password_when_tty
andtest_get_password_when_not_tty
.Please have a look at the test because is my first time doing unit testing in python with these libraries.
Thank you!