search

cevoaustralia / aws-google-auth

Provides AWS STS credentials based on Google Apps SAML SSO auth (what a jumble!)
MIT License
537 stars 181 forks source link

No credential exports printed when using docker. #96

Closed jtszalay closed 5 years ago

jtszalay commented 6 years ago

The credential exports aren't printed when using docker. It seems the config.profile has a value no matter what and the else that should print them is never reached.

wcharaka commented 6 years ago

@jgissend10 I think you are right. It seems in Configuration the self.profile is defaults to sts hence 

if config.profile:
        config.write(amazon_client)
else:
        amazon_client.print_export_line()

will always be true so it would never print. two options I can think of is either you can print it always. or you print based on a parameter. I find the latter more secure as I m not sure if we should just print the keys in the terminal. Thoughts..?

jtszalay commented 6 years ago

I'd prefer a parameter and to just replace the else with 'if parameter:' that way I can print it out even if we're writing the config to the client.

On Thu, Aug 16, 2018, 04:17 wcharaka notifications@github.com wrote:

@jgissend10 https://github.com/jgissend10 I think you are right. It seems in Configuration the self.profile is defaults to sts hence

if config.profile: config.write(amazon_client) else: amazon_client.print_export_line()

will always be true so it would never be true. two options I can think of is either you can print it always. or you print based on a parameter. I find the latter more secure as I m not sure if we should just print the keys in the terminal. Thoughts..?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/cevoaustralia/aws-google-auth/issues/96#issuecomment-413464339, or mute the thread https://github.com/notifications/unsubscribe-auth/AAj-vqxTL3iZWgk-qC9-1S6423u3hT0Tks5uRSqYgaJpZM4V4u5n .

stevemac007 commented 6 years ago

Agree, lets add an option to print the credentials so you have the option to use this no matter which way you use it.

jtszalay commented 5 years ago

Any update on this?

stevemac007 commented 5 years ago

@wcharaka are you still looking at this one, otherwise I'm happy to pick this up and get it working agin.

wcharaka commented 5 years ago

@stevemac007 I m on it..

wcharaka commented 5 years ago

This has been fixed and released.